-
Notifications
You must be signed in to change notification settings - Fork 118
[close #716] Fix pair #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportBase: 38.09% // Head: 37.89% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #724 +/- ##
============================================
- Coverage 38.09% 37.89% -0.21%
+ Complexity 1613 1605 -8
============================================
Files 278 278
Lines 17462 17469 +7
Branches 1984 1986 +2
============================================
- Hits 6653 6620 -33
- Misses 10154 10187 +33
- Partials 655 662 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host |
|
@Daemonxiao, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host |
|
@xuanyu66, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host |
pingyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
|
@pingyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host |
Signed-off-by: shiyuhang <1136742008@qq.com>
Signed-off-by: shiyuhang <1136742008@qq.com>
|
/cherry-pick release-3.3 |
|
@wuhuizuo: new pull request created to branch DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: shiyuhang <1136742008@qq.com>
What problem does this PR solve?
Issue Number: close #716
Problem Description: TBD
What is changed and how does it work?
override equals and hashcode
Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes