Skip to content

Conversation

@shiyuhang0
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #716

Problem Description: TBD

What is changed and how does it work?

override equals and hashcode

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has methods of interface change
  • Has persistent data change
  • No code

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Possible performance regression, WHY: TBD
  • Increased code complexity, WHY: TBD
  • Breaking backward compatibility, WHY: TBD
  • NO side effects

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note
  • NO related changes

Signed-off-by: shiyuhang <1136742008@qq.com>
@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Base: 38.09% // Head: 37.89% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (c0cb214) compared to base (dda1029).
Patch coverage: 28.57% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #724      +/-   ##
============================================
- Coverage     38.09%   37.89%   -0.21%     
+ Complexity     1613     1605       -8     
============================================
  Files           278      278              
  Lines         17462    17469       +7     
  Branches       1984     1986       +2     
============================================
- Hits           6653     6620      -33     
- Misses        10154    10187      +33     
- Partials        655      662       +7     
Impacted Files Coverage Δ
src/main/java/org/tikv/common/util/Pair.java 53.84% <28.57%> (-29.49%) ⬇️
src/main/java/org/tikv/common/pd/PDError.java 0.00% <0.00%> (-30.31%) ⬇️
...java/org/tikv/common/operation/PDErrorHandler.java 40.00% <0.00%> (-20.00%) ⬇️
src/main/java/org/tikv/common/region/TiStore.java 56.41% <0.00%> (-5.13%) ⬇️
...va/org/tikv/common/region/StoreHealthyChecker.java 69.62% <0.00%> (-3.80%) ⬇️
src/main/java/io/grpc/stub/ClientCalls.java 46.20% <0.00%> (-2.32%) ⬇️
...ty/handler/codec/http2/Http2ConnectionHandler.java 45.96% <0.00%> (-0.98%) ⬇️
src/main/java/io/grpc/internal/ClientCallImpl.java 56.65% <0.00%> (-0.73%) ⬇️
src/main/java/org/tikv/common/PDClient.java 58.62% <0.00%> (-0.24%) ⬇️
src/main/java/org/tikv/txn/TxnExpireTime.java 73.68% <0.00%> (+10.52%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-srebot
Copy link
Collaborator

@zhangyangyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host

@ti-srebot
Copy link
Collaborator

@Daemonxiao, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host

@ti-srebot
Copy link
Collaborator

@xuanyu66, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host

Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@ti-srebot
Copy link
Collaborator

@pingyu, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. get siglist: dial tcp 172.16.4.167:34000: connect: no route to host

@zhangyangyu zhangyangyu merged commit 2c48b4a into tikv:master Mar 3, 2023
shiyuhang0 added a commit to shiyuhang0/client-java that referenced this pull request Mar 6, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
shiyuhang0 added a commit to shiyuhang0/client-java that referenced this pull request Mar 6, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
@wuhuizuo
Copy link

wuhuizuo commented Mar 6, 2023

/cherry-pick release-3.3

@ti-chi-bot
Copy link
Member

@wuhuizuo: new pull request created to branch release-3.3: #727.

Details

In response to this:

/cherry-pick release-3.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

shiyuhang0 added a commit to shiyuhang0/client-java that referenced this pull request Mar 7, 2023
Signed-off-by: shiyuhang <1136742008@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

commit secondaryKeys fail to group by region

8 participants