Skip to content

[fix #740] Add more logs in getregionstore #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiyuhang0 merged 8 commits into from
May 31, 2023
Merged

[fix #740] Add more logs in getregionstore #751

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
457fb06
optimize getregionstore logical
shiyuhang0 May 24, 2023
967cfa5
decrease impact
shiyuhang0 May 25, 2023
c9b9472
Update RegionManager.java
shiyuhang0 May 25, 2023
35cd4e1
[close #749] Fix health checking issue (#748)
shiyuhang0 May 25, 2023
5d49990
Update RegionManager.java
shiyuhang0 May 25, 2023
a01479b
add log
shiyuhang0 May 29, 2023
42afccd
Merge branch 'master' into pinterest_epoch_not_match
shiyuhang0 May 30, 2023
d915e50
change log level
shiyuhang0 May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/main/java/org/tikv/common/region/RegionManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,13 @@ public TiRegion getRegionByKey(ByteString key, BackOffer backOffer) {
Pair<Metapb.Region, Metapb.Peer> regionAndLeader = pdClient.getRegionByKey(backOffer, key);
region =
cache.putRegion(createRegion(regionAndLeader.first, regionAndLeader.second, backOffer));
logger.debug(
String.format(
"get region id: %d with leader: %d",
region.getId(), region.getLeader().getStoreId()));
}
} catch (Exception e) {
logger.warn("Get region failed: ", e);
return null;
} finally {
requestTimer.observeDuration();
Expand Down Expand Up @@ -240,6 +245,10 @@ public Pair<TiRegion, TiStore> getRegionStorePairByKey(
}
logger.info("Store {} is unreachable, try to get the next replica", peer.getStoreId());
}
// Does not set unreachable store to null in case it is incompatible with GrpcForward
if (store == null || !store.isReachable()) {
logger.warn("No TiKV store available for region: " + region);
}
} else {
List<TiStore> tiflashStores = new ArrayList<>();
for (Peer peer : region.getLearnerList()) {
Expand Down