Skip to content

[close #774] Add TwoPhaseCommitter new Constructor contains executorService(#774) #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shiyuhang0 merged 5 commits into from
Jun 4, 2024
Merged

[close #774] Add TwoPhaseCommitter new Constructor contains executorService(#774) #775

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
178c948
add TwoPhaseCommitter new Constructor contains executorService(#774)
Jan 17, 2024
9eb11f7
[close #671] remove shadowing of netty && grpc (#781)
iosmanthus Mar 28, 2024
cfe12d0
[close #782] bump grpc to 1.60.0 (#783)
iosmanthus Mar 28, 2024
604eafb
[close #774]remove redundant code
Jun 3, 2024
40ec78d
Merge branch 'master' into feature/2pc
shiyuhang0 Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/main/java/org/tikv/txn/TwoPhaseCommitter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ public TwoPhaseCommitter(TiSession session, long startTime) {
}

public TwoPhaseCommitter(TiSession session, long startTime, long lockTTL) {
this(session, startTime, lockTTL, createExecutorService(WRITE_BUFFER_SIZE));
}

public TwoPhaseCommitter(
Copy link
Collaborator

@shiyuhang0 shiyuhang0 Jun 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change previous constructor method to this(session,startTime,lockTTL,createExecutorService(WRITE_BUFFER_SIZE));
image

TiSession session, long startTime, long lockTTL, ExecutorService executorService) {
this(
session,
startTime,
Expand All @@ -98,7 +103,7 @@ public TwoPhaseCommitter(TiSession session, long startTime, long lockTTL) {
1,
true,
3,
createExecutorService(WRITE_BUFFER_SIZE));
executorService);
}

TwoPhaseCommitter(
Expand Down