Skip to content

Build our own protos#192

Merged
nrc merged 2 commits intotikv:masterfrom
nrc:proto
Nov 1, 2020
Merged

Build our own protos#192
nrc merged 2 commits intotikv:masterfrom
nrc:proto

Conversation

@nrc
Copy link
Copy Markdown
Collaborator

@nrc nrc commented Oct 30, 2020

I've copied protos from kvproto so we no longer need that dependency, then we build them ourselves, so we only need the Prost versions. That means we don't need any Git dependencies or need to replace any deps (and can publish the client crates).

Closes #32

PTAL @ekexium

nrc added 2 commits October 30, 2020 14:43
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
@ekexium
Copy link
Copy Markdown
Collaborator

ekexium commented Oct 30, 2020

LGTM.
According to @sticnarf, TiKV is always backward compatible. Thus, we don't have to manually copy any future changes applied to kvproto. But we should clearly state the lowest required version of TiKV server.

@nrc
Copy link
Copy Markdown
Collaborator Author

nrc commented Oct 30, 2020

According to @sticnarf, TiKV is always backward compatible. Thus, we don't have to manually copy any future changes applied to kvproto.

True, but we will need to copy them if we wish to support new features

But we should clearly state the lowest required version of TiKV server.

Agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolving blockers for publishing

2 participants