Use command line args in examples.#20
Merged
Hoverbear merged 21 commits intotikv:masterfrom Jan 14, 2019
Merged
Conversation
Note: raw::Client::batch_scan is not implemented yet. Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Xiaoguang Sun <sunxiaoguang@zhihu.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Contributor
Collaborator
Author
|
@Hoverbear This pr intends to be merged into sun/raw_kv_initial_version, so I think it can be merged prior to that. |
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
siddontang
reviewed
Jan 13, 2019
siddontang
reviewed
Jan 13, 2019
siddontang
reviewed
Jan 14, 2019
siddontang
reviewed
Jan 14, 2019
siddontang
reviewed
Jan 14, 2019
siddontang
reviewed
Jan 14, 2019
Contributor
|
PTAL @Hoverbear |
Contributor
|
PTAL @sunxiaoguang |
sticnarf
force-pushed
the
use-clap-for-example
branch
from
a6ee50c to
9f5ec20
Compare
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
force-pushed
the
use-clap-for-example
branch
from
9f5ec20 to
10e3f6a
Compare
Collaborator
Author
|
Latest changes are merged into this branch. Now I change the base branch of this PR to master. |
Hoverbear
approved these changes
Jan 14, 2019
Contributor
|
This LGTM. Merging now, red build jobs are due to misconfigured CI (we configured it during a brownout 🙄 My bad.) The lint is existing so not related to this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am happy to help with #16.
The clap work is put in a separate function to avoid messing up the
main.Not returning a
Configdirectly fromparse_argsis meant to keep the code of creating aConfigin view.