Conversation
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
force-pushed
the
kvproto-bump
branch
from
dbb44ce to
72353e9
Compare
Contributor
|
You can do it, although publishing kvproto seems strange :-) |
Contributor
Author
|
@siddontang I agree, but we must consider how to support it being used in multiple crates that may be published. :( |
Hoverbear
commented
Feb 13, 2019
Contributor
Author
Hoverbear
left a comment
Hoverbear
left a comment
There was a problem hiding this comment.
@AndreMouche PTAL, CI failure is expected.
3 tasks
Signed-off-by: Ana Hobden <operator@hoverbear.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps KVproto to latest master as it broke our build in a recent commit. This also locks us to a particular revision for the time being.
@siddontang we need to consider if we will publish kvproto. This lib cannot be published unless its dependencies are.