Conversation
|
@dcalvin PTAL. |
dcalvin
reviewed
Feb 12, 2019
dcalvin
reviewed
Feb 12, 2019
dcalvin
reviewed
Feb 12, 2019
dcalvin
reviewed
Feb 12, 2019
dcalvin
reviewed
Feb 12, 2019
dcalvin
reviewed
Feb 12, 2019
dcalvin
reviewed
Feb 12, 2019
dcalvin
reviewed
Feb 12, 2019
dcalvin
reviewed
Feb 12, 2019
Hoverbear
force-pushed
the
readme-and-lib-docs
branch
2 times, most recently
from
750c7a6 to
43fa973
Compare
brson
requested changes
Feb 12, 2019
Contributor
brson
left a comment
brson
left a comment
There was a problem hiding this comment.
Looks good. Please answer my questions and resolve my comments as you see fit, and I'll approve.
3 tasks
brson
approved these changes
Feb 15, 2019
Contributor
|
Needs sign off, but it's good to merge after. |
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Nit fixes. Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
force-pushed
the
readme-and-lib-docs
branch
from
8b0e63c to
104509f
Compare
Contributor
Author
|
Merging, CI still red. |
|
I believe CI is failing due to the organization transfer. |
Contributor
Author
|
@ice1000 The CI is failing because of the recent kvproto update as well as the need for a recent raft release. :( |
|
Wooo. So the badge's URL in README need to be updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a first pass of README and the crate level docs.
Edit (brson): Rendered README