Skip to content

build: Make sure tikv-client works on stable rust#412

Merged
sticnarf merged 3 commits intotikv:masterfrom
Xuanwo:stable-support
Jul 16, 2023
Merged

build: Make sure tikv-client works on stable rust#412
sticnarf merged 3 commits intotikv:masterfrom
Xuanwo:stable-support

Conversation

@Xuanwo
Copy link
Copy Markdown
Member

@Xuanwo Xuanwo commented Jul 14, 2023

This PR add rust-toolchain.toml for this project to make sure all our development happen under the stable rust version.

It would be ideal to have an MSRV policy, but it is not urgent. We can establish one once we have a sufficient user base.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jul 14, 2023

cc @andylokandy, @ekexium & @pingyu, would you like to take a review? Thanks!

Comment thread rustfmt.toml
Copy link
Copy Markdown
Collaborator

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Copy Markdown
Member Author

Xuanwo commented Jul 16, 2023

Fixed, please review again @sticnarf

@sticnarf sticnarf merged commit 2761270 into tikv:master Jul 16, 2023
@sticnarf
Copy link
Copy Markdown
Collaborator

Thanks @Xuanwo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants