Fix reverse scan for scene of multiple regions#438
Merged
iosmanthus merged 2 commits intotikv:masterfrom Nov 28, 2023
Merged
Conversation
Signed-off-by: Ping Yu <yuping@pingcap.com>
Collaborator
Author
|
CC @jmhrpr. Thank you for providing the clue! I will fix it this weekend. |
Signed-off-by: Ping Yu <yuping@pingcap.com>
iosmanthus
approved these changes
Nov 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #436
Fix the issue by swap
start_key&end_keybefore requesting regions from PD, and swap back before apply shards to request. As thestart_key&end_keyin reverse range request are in the meaning of[end_key, start_key).The issue can be reproduced before the
shardable_rangewas fixed. See 435cf0a:See also https://github.com/tikv/client-rust/actions/runs/6989951811/job/19018973704?pr=438.