Resolving the TLS url issue#459
Merged
pingyu merged 3 commits intotikv:masterfrom Jun 27, 2024
Merged
Conversation
Signed-off-by: limbooverlambda <schakra1@gmail.com>
Collaborator
|
Thanks for your contribution ! Please fix the error of "make check" in CI. Rest LGTM~ |
Signed-off-by: limbooverlambda <schakra1@gmail.com>
Signed-off-by: limbooverlambda <schakra1@gmail.com>
2 tasks
yongman
added a commit
to pingyu/client-rust
that referenced
this pull request
Jan 9, 2025
Signed-off-by: Ray Yan <yming0221@gmail.com>
emmanuel-keller
pushed a commit
to surrealdb/tikv-client
that referenced
this pull request
May 29, 2025
Signed-off-by: Ray Yan <yming0221@gmail.com> (cherry picked from commit 83ad811)
emmanuel-keller
pushed a commit
to surrealdb/tikv-client
that referenced
this pull request
May 29, 2025
Signed-off-by: Ray Yan <yming0221@gmail.com> (cherry picked from commit 83ad811)
4 tasks
pingyu
pushed a commit
to pingyu/client-rust
that referenced
this pull request
Jan 25, 2026
* resolving the url issue Signed-off-by: limbooverlambda <schakra1@gmail.com> * fix formatting Signed-off-by: limbooverlambda <schakra1@gmail.com> * make check fixes Signed-off-by: limbooverlambda <schakra1@gmail.com> --------- Signed-off-by: limbooverlambda <schakra1@gmail.com> Signed-off-by: Ping Yu <yuping@pingcap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While running the client we are running into issues where the client fails to connect to a TLS enabled PD endpoint with the error:
[WARN] [config_logging.go:287] ["rejected connection"] [remote-addr="[addr]:port"] [server-name=] [error="tls: first record does not look like a TLS handshake"]
Digging into the code, the problem seems to stem from the following logic in the client (
client-rust/src/common/security.rs
Line 80 in c6110dd
Here SCHEME_REG is the regex to find "https" in the prefix of the address (
client-rust/src/common/security.rs
Line 19 in c6110dd
This is a problem during the ssl handshake since the server is not acknowledging the requests sent to an addressed prefixed with "http" instead of "https". Adding the logic to handle these variations.