Skip to content

plan: Handle no leader and invalidate store region#478

Merged
coocood merged 23 commits intotikv:csefrom
pingyu:handle-no-leader
Mar 17, 2025
Merged

plan: Handle no leader and invalidate store region#478
coocood merged 23 commits intotikv:csefrom
pingyu:handle-no-leader

Conversation

@pingyu
Copy link
Copy Markdown
Collaborator

@pingyu pingyu commented Mar 17, 2025

Close #479 #480

Changes

  • When meet the no leader error, invalidate region cache and retry.
  • When meet gRPC error, invalidate store cache.

Note:

The change of txn_split_batch is because the case can not finish in 3 minutes, and the logs of TiKV & PD show that the reason is writing data is too slow.

But the master does not have this issue.

But this PR should not affect this case.

Investigate the root cause later. Reduce the size of data for work around.

pingyu added 21 commits March 12, 2025 12:24
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 17, 2025
pingyu added 2 commits March 17, 2025 15:59
Signed-off-by: Ping Yu <yuping@pingcap.com>
Signed-off-by: Ping Yu <yuping@pingcap.com>
@pingyu pingyu changed the title plan: Handle no leader error plan: Handle no leader and invalidate store region Mar 17, 2025
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 17, 2025

@iosmanthus: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 17, 2025

@coocood: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: coocood, iosmanthus

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coocood coocood merged commit 8f81873 into tikv:cse Mar 17, 2025
emmanuel-keller pushed a commit to surrealdb/tikv-client that referenced this pull request May 29, 2025
Signed-off-by: Ping Yu <yuping@pingcap.com>
(cherry picked from commit 8f81873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants