Skip to content

transaction: Fix addition overflow of scan_and_fetch#515

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
pingyu:fix-scan-and-fetch-overflow
Jan 14, 2026
Merged

transaction: Fix addition overflow of scan_and_fetch#515
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
pingyu:fix-scan-and-fetch-overflow

Conversation

@pingyu
Copy link
Copy Markdown
Collaborator

@pingyu pingyu commented Jan 14, 2026

Close #514

Changes

Use saturating_add to avoid overflow.

Signed-off-by: Ping Yu <yuping@pingcap.com>
@ti-chi-bot ti-chi-bot Bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 14, 2026
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 14, 2026
@ti-chi-bot ti-chi-bot Bot added the lgtm label Jan 14, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 14, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coocood, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 14, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot Bot commented Jan 14, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-14 04:44:38.595621293 +0000 UTC m=+419122.657486212: ☑️ agreed by coocood.
  • 2026-01-14 04:51:23.104909058 +0000 UTC m=+419527.166773947: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot Bot merged commit 1c1b2e0 into tikv:master Jan 14, 2026
10 of 11 checks passed
pingyu added a commit to pingyu/client-rust that referenced this pull request Jan 25, 2026
close tikv#514

Signed-off-by: Ping Yu <yuping@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Arithmetic overflow panic when scan limit is u32::MAX and buffer contains deleted entries

3 participants