*:process approximate rows in region#1104
Conversation
|
|
| kind |= (schedule.OpRegion | schedule.OpLeader) | ||
| c.Assert(op.Kind()&kind, check.Equals, kind) | ||
| } | ||
| // Copyright 2017 PingCAP, Inc. |
There was a problem hiding this comment.
why this file has so many changes?
There was a problem hiding this comment.
Since I do gofmt with go version go1.10.1 darwin/amd64 ?
There was a problem hiding this comment.
It looks like that old file is not well formatted. (apparently make check skips all files in testutil, no idea why...)
| saveCache = true | ||
| } | ||
| if region.ApproximateRows != origin.ApproximateRows { | ||
| saveCache = true |
There was a problem hiding this comment.
Is the ApproximateRows too sensitive to change?
There was a problem hiding this comment.
I think it should be ok as long as they are only saved to cache (not to etcd).
| RegionRows int64 | ||
| RegionCount int64 | ||
| LeaderSize int64 | ||
| LeaderRows int64 |
There was a problem hiding this comment.
I think we can exclude RegionRows and LeaderRows in StoreInfluence.
|
LGTM. |
nolouch
left a comment
nolouch
left a comment
There was a problem hiding this comment.
LGTM. please update the proto.
4 participants
Hi
This PR process the approximate rows in the region from the heartbeat request.
@nolouch @disksing PTAL