schedule: fix a deadlock in GetOpInfluence#1340
Merged
Merged
Conversation
disksing
reviewed
Nov 22, 2018
| oc.GetOpInfluence(tc) | ||
| } | ||
| }() | ||
| time.Sleep(1 * time.Second) |
Contributor
There was a problem hiding this comment.
Don't sleep. Use waitGroup to save test time.
rleungx
added
the
do-not-merge/work-in-progress
disksing
approved these changes
Nov 22, 2018
rleungx
removed
the
do-not-merge/work-in-progress
nolouch
approved these changes
Nov 22, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#1310 changes the logic when getting
OpInfluenceand useGetOperatorinGetOpInfluence. These two functions both addRLockwhich might cause a deadlock.What is changed and how it works?
This PR uses
oc.operatorsdirectly rather than callGetOperatorinGetOpInfluence. Closes #1338.Check List
Tests