Skip to content

*: update go version to 1.13#1742

Merged
disksing merged 7 commits into
tikv:masterfrom
oh-my-tidb:1.13
Sep 10, 2019
Merged

*: update go version to 1.13#1742
disksing merged 7 commits into
tikv:masterfrom
oh-my-tidb:1.13

Conversation

@disksing
Copy link
Copy Markdown
Contributor

@disksing disksing commented Sep 9, 2019

What problem does this PR solve?

  • After upgrading go to 1.13, make dev complains about github.com/golang/protobuf/proto/testdata not found.
  • After make ci, theres is a unstaged result.txt file.

What is changed and how it works?

  • update go version to 1.13
  • update golang_protobuf_extensions to reference a new version of protobuf
  • update golang.org/x/{net, crypto, sync, sys} to latest
  • ignore result.txt file for git

Check List

Tests

  • No code

Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@disksing disksing added the component/util Utility. label Sep 9, 2019
@disksing disksing requested review from Luffbee and nolouch September 9, 2019 08:52
@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9098f21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1742   +/-   ##
=========================================
  Coverage          ?   76.91%           
=========================================
  Files             ?      161           
  Lines             ?    15749           
  Branches          ?        0           
=========================================
  Hits              ?    12114           
  Misses            ?     2617           
  Partials          ?     1018

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9098f21...5da12d3. Read the comment docs.

Signed-off-by: disksing <i@disksing.com>
@disksing disksing changed the title *: fix CI error *: update go version to 1.13 Sep 9, 2019
@disksing disksing added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2019
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
@disksing disksing removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 10, 2019
@disksing
Copy link
Copy Markdown
Contributor Author

/test

@disksing
Copy link
Copy Markdown
Contributor Author

/rebuild

@disksing
Copy link
Copy Markdown
Contributor Author

PTAL @nolouch @rleungx @Luffbee

@rleungx rleungx added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Sep 10, 2019
@sre-bot
Copy link
Copy Markdown
Contributor

sre-bot commented Sep 10, 2019

/run-all-tests

@rleungx rleungx removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 10, 2019
@rleungx
Copy link
Copy Markdown
Member

rleungx commented Sep 10, 2019

Does this PR need to cherry-pick to release-3.x branches?

@disksing
Copy link
Copy Markdown
Contributor Author

We will manually update release branches after our CI environment is updated. @rleungx

@disksing disksing merged commit e678a1f into tikv:master Sep 10, 2019
@disksing disksing deleted the 1.13 branch September 10, 2019 06:54
Luffbee added a commit that referenced this pull request Sep 11, 2019
* *: unify get store function everywhere (#1671)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

*  server: use leader lease to determine tso service validity (#1676)

Signed-off-by: disksing <i@disksing.com>

* test: fix tests (#1696)

* test: fix region syncer test

Signed-off-by: disksing <i@disksing.com>

* add config-check flag for pd-server (#1695)

Signed-off-by: cwen0 <cwenyin0@gmail.com>

* operator: rewrite move region related functions (#1667)

* *: support setting endKey for ScanRange (#1700)

Signed-off-by: disksing <i@disksing.com>

* *: reduce some unnecessary parameters (#1698)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: Do not send an operator of a region wth a stale epoch (#1659)

* schedule: Do not send an operator of a region wth a stale epoch

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* schedule: check the version changed by the operator self

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* schedule: fix unit test

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* schedule: fix to avoid dispatching a stale opstep

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* dispatch: refactor "ConsumeConfVer() int" to "ExpectConfVerChange() bool"

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* dispatch: fix typo in comment

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* fix typo

Co-Authored-By: Ryan Leung <rleungx@gmail.com>

* dispatch: fix unittest

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* dispatch: refine format

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* server: fix the dead lock in scatter region (#1706)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* tools: fix set namespace in pd-ctl (#1701)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* tools: fix parse url without http prefix (#1703)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* tests: support deadlock detection in make test (#1704)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* Makefile: fix failpoint enable (#1722)

Signed-off-by: nolouch <nolouch@gmail.com>

* checker: fix the issue that a region does not merge to the sibling with smaller size (#1723)

Signed-off-by: disksing <i@disksing.com>

* tools: balance region simulator (#1708)

* scheduler: do not remove the operator when the step does not finish (#1715)

Signed-off-by: Shafreeck Sea <shafreeck@gmail.com>

* operator: fix the AddLearner config version judgment (#1732)

Signed-off-by: nolouch <nolouch@gmail.com>

* tools: fix TLS in pd control (#1729)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* syncer: support TLS for region syncer (#1728)

Signed-off-by: Ryan Leung <rleungx@gmail.com>

* schedule: fix a thread-safe bug and improve code (#1719)

* statistics: fix region flow calculation (#1688)

Signed-off-by: jiyingtk <jiyingtk@mail.ustc.edu.cn>

* makefile: improve deadlock-enable/disable (#1736)

* api: fix missing keys statistic in region information (#1741)

Signed-off-by: nolouch <nolouch@gmail.com>

* *: update go version to 1.13 (#1742)

Signed-off-by: disksing <i@disksing.com>

* coordinator: add the operator cost time in log field (#1748)

Signed-off-by: nolouch <nolouch@gmail.com>
overvenus pushed a commit to overvenus/pd that referenced this pull request Oct 17, 2019
Signed-off-by: disksing <i@disksing.com>
overvenus added a commit that referenced this pull request Oct 18, 2019
Signed-off-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/util Utility. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants