tso: Fix Local tso alloactor become alloactor leader without pd leader knowing its dc-location#3134
Merged
Merged
Conversation
Signed-off-by: Song Gao <disxiaofei@163.com>
JmPotato
reviewed
Nov 2, 2020
Signed-off-by: Song Gao <disxiaofei@163.com>
JmPotato
reviewed
Nov 2, 2020
Member
JmPotato
left a comment
JmPotato
left a comment
There was a problem hiding this comment.
Basically LGTM, could you please add a test for this feature then?
Signed-off-by: Song Gao <disxiaofei@163.com>
JmPotato
approved these changes
Nov 3, 2020
Signed-off-by: Song Gao <disxiaofei@163.com>
Contributor
Author
|
/merge |
Member
|
@Yisaer: you cannot merge your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository. |
HunDunDM
approved these changes
Nov 4, 2020
ti-chi-bot
added
status/LGT2
Member
|
/merge |
ti-chi-bot
added
the
status/can-merge
Member
|
Can merge label has been added. DetailsGit tree hash: 0743edebc1ce6125831caaa1c1b79e59d9f370bd |
Member
|
/rebase |
Member
|
/run-all-tests |
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
Signed-off-by: Song Gao <disxiaofei@163.com>
github-actions
Bot
force-pushed
the
fix_tso_unknown
branch
from
4d68177 to
8685702
Compare
Member
|
New changes are detected. Can merge label has been removed. |
ti-chi-bot
removed
the
status/can-merge
Member
|
/run-all-tests |
1 similar comment
Member
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/merge |
Member
|
@Yisaer: you cannot merge your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository. |
longfangsong
pushed a commit
to longfangsong/pd
that referenced
this pull request
Nov 5, 2020
…r knowing its dc-location (tikv#3134) Signed-off-by: longfangsong <longfangsong@icloud.com>
ti-chi-bot
added a commit
that referenced
this pull request
Nov 27, 2020
* tso: Fix Local tso alloactor become alloactor leader without pd leader knowing its dc-location (#3134) Signed-off-by: longfangsong <longfangsong@icloud.com> * persist to etcd Signed-off-by: longfangsong <longfangsong@icloud.com> * load on boot and change leader Signed-off-by: longfangsong <longfangsong@icloud.com> * Apply several suggestion from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * extract getTTLUint and getTTLFloat Signed-off-by: longfangsong <longfangsong@icloud.com> * extract EtcdKVPutWithTTL Signed-off-by: longfangsong <longfangsong@icloud.com> * format with goimports Signed-off-by: longfangsong <longfangsong@icloud.com> * support leader-schedule-limit Signed-off-by: longfangsong <longfangsong@icloud.com> * add tests Signed-off-by: longfangsong <longfangsong@icloud.com> * support hot-region-schedule-limit & replica-schedule-limit & merge-schedule-limit Signed-off-by: longfangsong <longfangsong@icloud.com> * add integration test and fix a bug Signed-off-by: longfangsong <longfangsong@icloud.com> * cleanup tests Signed-off-by: longfangsong <longfangsong@icloud.com> * Apply some suggestions from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * extract getTTLFloatOr Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions from code review Signed-off-by: longfangsong <longfangsong@icloud.com> * make TestConfigTTLAfterTransferLeader run Serial to prevent it affect TestScatterRegion Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions from code reviewing Signed-off-by: longfangsong <longfangsong@icloud.com> * apply suggestions in code review Signed-off-by: longfangsong <longfangsong@icloud.com> * make the testing time as little as possible Signed-off-by: longfangsong <longfangsong@icloud.com> Co-authored-by: Song Gao <disxiaofei@163.com> Co-authored-by: Ti Prow Robot <71242396+ti-community-prow-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Song Gao disxiaofei@163.com
What problem does this PR solve?
fix #3124
ref pingcap/kvproto#688
What is changed and how it works?
During
allocatorLeaderLoop, the Allocator should query the dcLocations from leader to be sured that the pd leader is aware of this dc-location.Check List
Tests
Release note