Skip to content

Update the errors and tiup repositories to the latest version#3170

Merged
ti-chi-bot merged 2 commits into
masterfrom
update-errors
Nov 9, 2020
Merged

Update the errors and tiup repositories to the latest version#3170
ti-chi-bot merged 2 commits into
masterfrom
update-errors

Conversation

@lonng
Copy link
Copy Markdown
Member

@lonng lonng commented Nov 9, 2020

Signed-off-by: Lonng heng@lonng.org

What problem does this PR solve?

Update the errors and TiUP to the latest version to make the error documentation work well. The PR pingcap/tiup#867 introduces functions that will merge the workaround/description from errors.toml with the error message from the repository. Make sure there are no conflicts between code and error metafile, the PR pingcap/errors#31 remove workaround/description options.

What is changed and how it works?

Check List

Tests

  • No code

Release note

None

Signed-off-by: Lonng <heng@lonng.org>
@JmPotato
Copy link
Copy Markdown
Member

JmPotato commented Nov 9, 2020

Files errors.toml and errors.toml.before differ

Please fix this first, thx.

Signed-off-by: Lonng <heng@lonng.org>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 9, 2020
@JmPotato
Copy link
Copy Markdown
Member

JmPotato commented Nov 9, 2020

/lgtm

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 9, 2020
@lonng
Copy link
Copy Markdown
Member Author

lonng commented Nov 9, 2020

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@lonng: you cannot merge your own PR.

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

@lonng: It seems you want to merge this PR, I will help you trigger all the tests:
/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Nov 9, 2020

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:
/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2020
@ti-chi-bot
Copy link
Copy Markdown
Member

Can merge label has been added.

DetailsGit tree hash: dab66ed

@lonng
Copy link
Copy Markdown
Member Author

lonng commented Nov 9, 2020

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@lonng: It seems you want to merge this PR, I will help you trigger all the tests:
/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@tikv tikv deleted a comment from ti-chi-bot Nov 9, 2020
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Nov 9, 2020

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:
/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/prow-config repository.

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Nov 9, 2020

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit c03da27 into master Nov 9, 2020
@lonng lonng deleted the update-errors branch November 9, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants