Skip to content

server/scheduler: Do not remove the down peer until the normal peers are enough#3335

Merged
ti-chi-bot merged 5 commits into
tikv:masterfrom
AndreMouche:check_voters_before_remove
Jan 6, 2021
Merged

server/scheduler: Do not remove the down peer until the normal peers are enough#3335
ti-chi-bot merged 5 commits into
tikv:masterfrom
AndreMouche:check_voters_before_remove

Conversation

@AndreMouche
Copy link
Copy Markdown
Member

@AndreMouche AndreMouche commented Jan 5, 2021

Signed-off-by: shirly AndreMouche@126.com

What problem does this PR solve?

Issue Number: close #3117

What is changed and how it works?

Do not remove the down peer until the normal peers are enough

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Release note

Do not remove the down peer until the normal peers are enough

@ti-chi-bot ti-chi-bot requested review from JmPotato and lhy1024 January 5, 2021 13:40
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 5, 2021

Codecov Report

Merging #3335 (2b573ce) into master (1691df2) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3335      +/-   ##
==========================================
- Coverage   74.81%   74.69%   -0.12%     
==========================================
  Files         243      243              
  Lines       23136    23136              
==========================================
- Hits        17309    17282      -27     
- Misses       4262     4276      +14     
- Partials     1565     1578      +13     
Flag Coverage Δ
unittests 74.69% <100.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/checker/replica_checker.go 70.58% <100.00%> (ø)
server/tso/local_allocator.go 74.24% <0.00%> (-7.58%) ⬇️
server/region_syncer/server.go 83.20% <0.00%> (-6.11%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/region_syncer/client.go 78.74% <0.00%> (-4.73%) ⬇️
pkg/dashboard/adapter/manager.go 81.52% <0.00%> (-3.27%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-1.67%) ⬇️
server/server.go 71.99% <0.00%> (-0.95%) ⬇️
server/config/persist_options.go 91.33% <0.00%> (-0.79%) ⬇️
server/cluster/coordinator.go 73.57% <0.00%> (-0.72%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1691df2...2b573ce. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 6, 2021
Copy link
Copy Markdown
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 6, 2021
@Yisaer
Copy link
Copy Markdown
Contributor

Yisaer commented Jan 6, 2021

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 12a8d90

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 6, 2021
@ti-chi-bot
Copy link
Copy Markdown
Member

@AndreMouche: Your PR has out-of-dated, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/ti-community-prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not remove the down peer until the normal peers are enough

4 participants