Unified Log Format RFC#18
Merged
huachaohuang merged 10 commits intomasterfrom Jan 7, 2019
Merged
Conversation
Signed-off-by: Breezewish <breezewish@pingcap.com>
breezewish
force-pushed
the
log-format-standard
branch
from
6073917 to
7e6a4af
Compare
This comment has been minimized.
This comment has been minimized.
overvenus
reviewed
Dec 20, 2018
breezewish
force-pushed
the
log-format-standard
branch
from
fcf085e to
0fcac72
Compare
Signed-off-by: Breezewish <breezewish@pingcap.com>
breezewish
force-pushed
the
log-format-standard
branch
from
0fcac72 to
a016108
Compare
Hoverbear
added
the
Initial Comment Period
Signed-off-by: Breezewish <breezewish@pingcap.com>
breezewish
force-pushed
the
log-format-standard
branch
from
74221fa to
84563b8
Compare
Member
Author
|
Comments addressed, mainly in the following aspects:
@overvenus @BusyJay @lysu @siddontang @shenli PTAL, thanks! |
overvenus
reviewed
Jan 2, 2019
Signed-off-by: Breezewish <breezewish@pingcap.com>
breezewish
force-pushed
the
log-format-standard
branch
from
f4fc44e to
47081f6
Compare
Signed-off-by: Breezewish <breezewish@pingcap.com>
Signed-off-by: Breezewish <breezewish@pingcap.com>
overvenus
added
Final Comment Period
overvenus
approved these changes
Jan 7, 2019
|
|
||
| Sample: `2018/12/15 14:20:11.015 +08:00` | ||
|
|
||
| - `LEVEL`: The log level in upper case. Available levels are `FATAL`, `ERROR`, |
There was a problem hiding this comment.
Do we need to add the definition / meaning of each level here?
Member
Author
There was a problem hiding this comment.
Nop, this RFC is only for formats. We have another internal doc stipulates what kind of logs are in what level.
Signed-off-by: Breezewish <breezewish@pingcap.com>
Hoverbear
pushed a commit
to sunxiaoguang/rfcs
that referenced
this pull request
Feb 21, 2019
* unified log format Signed-off-by: Breezewish <breezewish@pingcap.com> Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
pushed a commit
to sunxiaoguang/rfcs
that referenced
this pull request
Feb 21, 2019
* unified log format Signed-off-by: Wenxuan Shi <breezewish@pingcap.com> Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear
pushed a commit
to sunxiaoguang/rfcs
that referenced
this pull request
Feb 21, 2019
* unified log format Signed-off-by: Wenxuan Shi <hi@breeswish.org> Signed-off-by: Ana Hobden <operator@hoverbear.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.