Skip to content

RFC: PD Simulator#20

Merged
huachaohuang merged 5 commits intotikv:masterfrom
rleungx:pd-simulator
Jan 28, 2019
Merged

RFC: PD Simulator#20
huachaohuang merged 5 commits intotikv:masterfrom
rleungx:pd-simulator

Conversation

@rleungx
Copy link
Copy Markdown
Member

@rleungx rleungx commented Jan 8, 2019

The RFC of PD Simulator.

Signed-off-by: rleungx <rleungx@gmail.com>
@rleungx rleungx added the Initial Comment Period This RFC is in the initial comment period, and has quite some time to give input on. label Jan 8, 2019
@rleungx rleungx self-assigned this Jan 9, 2019
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
@lilin90
Copy link
Copy Markdown
Member

lilin90 commented Jan 14, 2019

@CaitinChen Please help review this PR. Thanks!

@huachaohuang huachaohuang requested review from CaitinChen and removed request for lilin90 January 14, 2019 09:29
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Signed-off-by: rleungx <rleungx@gmail.com>
Copy link
Copy Markdown
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md
Signed-off-by: rleungx <rleungx@gmail.com>
@huachaohuang
Copy link
Copy Markdown
Contributor

@CaitinChen PTAL

@huachaohuang
Copy link
Copy Markdown
Contributor

@CaitinChen @lilin90 PTAL, thanks.

Comment thread text/2019-01-08-pd-simulator.md Outdated
Comment thread text/2019-01-08-pd-simulator.md Outdated
Signed-off-by: rleungx <rleungx@gmail.com>
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Jan 24, 2019

PTAL. @huachaohuang @CaitinChen

Copy link
Copy Markdown
Contributor

@huachaohuang huachaohuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huachaohuang huachaohuang merged commit d5dfc57 into tikv:master Jan 28, 2019
Hoverbear pushed a commit to sunxiaoguang/rfcs that referenced this pull request Feb 21, 2019
* introduce PD simulator

Signed-off-by: rleungx <rleungx@gmail.com>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear pushed a commit to sunxiaoguang/rfcs that referenced this pull request Feb 21, 2019
* introduce PD simulator

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear pushed a commit to sunxiaoguang/rfcs that referenced this pull request Feb 21, 2019
* introduce PD simulator

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Hoverbear pushed a commit to sunxiaoguang/rfcs that referenced this pull request Feb 21, 2019
* introduce PD simulator

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Initial Comment Period This RFC is in the initial comment period, and has quite some time to give input on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants