docs: replace deprecated PingCAP domains#361
Open
wuhuizuo wants to merge 1 commit intotikv:masterfrom
Open
Conversation
|
Welcome @wuhuizuo! It looks like this is your first PR to tikv/website 🎉 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (29)
✅ Files skipped from review due to trivial changes (27)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughUpdated documentation download and Helm chart URLs across multiple docs: replaced Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
content/docs/3.0/tasks/deploy/binary.md (1)
31-31: Note: Protocol inconsistency for SHA256 checksum URL.Line 31 (and line 101) use
http://instead ofhttps://for the SHA256 checksum download. While this is not introduced by this PR, consider updating tohttps://for consistency and security.🔒 Suggested protocol update
- wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 + wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256Apply the same change at line 101.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@content/docs/3.0/tasks/deploy/binary.md` at line 31, Update the SHA256 checksum download commands to use HTTPS instead of HTTP: locate the two wget lines that download "tidb-latest-linux-amd64.sha256" (the occurrences using "http://download.pingcap.com/tidb-latest-linux-amd64.sha256") and change their URLs to "https://download.pingcap.com/tidb-latest-linux-amd64.sha256" to ensure protocol consistency and security.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@content/docs/6.5/deploy/install/test.md`:
- Around line 89-90: The .sha256 checksum downloads use insecure HTTP; update
the wget invocations that fetch the checksum files (e.g., the lines invoking
wget http://download.pingcap.com/...tidb-latest-linux-amd64.sha256 and the other
similar .sha256 wget) to use HTTPS instead so the checksum cannot be tampered
with in transit; locate the wget commands that reference ".sha256" (the checksum
download commands) and replace "http://" with "https://" for each occurrence.
In `@content/docs/dev/deploy/install/test.md`:
- Line 90: Replace the insecure HTTP checksum download command so it uses HTTPS:
update the wget invocation that fetches "tidb-latest-linux-amd64.sha256" (and
the other occurrence around the same block) to use
https://download.pingcap.com/tidb-latest-linux-amd64.sha256 instead of http://
so the sha256 checksum file is fetched over TLS and cannot be modified in
transit.
---
Nitpick comments:
In `@content/docs/3.0/tasks/deploy/binary.md`:
- Line 31: Update the SHA256 checksum download commands to use HTTPS instead of
HTTP: locate the two wget lines that download "tidb-latest-linux-amd64.sha256"
(the occurrences using
"http://download.pingcap.com/tidb-latest-linux-amd64.sha256") and change their
URLs to "https://download.pingcap.com/tidb-latest-linux-amd64.sha256" to ensure
protocol consistency and security.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 50c181e7-a71a-433a-aad6-da9d5a8a1984
📒 Files selected for processing (29)
content/docs/3.0/tasks/deploy/binary.mdcontent/docs/3.0/tasks/try/tikv-operator.mdcontent/docs/4.0/tasks/deploy/binary.mdcontent/docs/4.0/tasks/try/tikv-operator.mdcontent/docs/5.1/deploy/install/test.mdcontent/docs/5.1/deploy/install/verify.mdcontent/docs/5.1/deploy/monitor/deploy.mdcontent/docs/5.1/reference/CLI/pd-ctl.mdcontent/docs/5.1/reference/CLI/pd-recover.mdcontent/docs/6.1/deploy/install/test.mdcontent/docs/6.1/deploy/install/verify.mdcontent/docs/6.1/deploy/monitor/deploy.mdcontent/docs/6.1/reference/CLI/pd-ctl.mdcontent/docs/6.1/reference/CLI/pd-recover.mdcontent/docs/6.5/deploy/install/test.mdcontent/docs/6.5/deploy/install/verify.mdcontent/docs/6.5/deploy/monitor/deploy.mdcontent/docs/6.5/reference/CLI/pd-ctl.mdcontent/docs/6.5/reference/CLI/pd-recover.mdcontent/docs/7.1/deploy/install/test.mdcontent/docs/7.1/deploy/install/verify.mdcontent/docs/7.1/deploy/monitor/deploy.mdcontent/docs/7.1/reference/CLI/pd-ctl.mdcontent/docs/7.1/reference/CLI/pd-recover.mdcontent/docs/dev/deploy/install/test.mdcontent/docs/dev/deploy/install/verify.mdcontent/docs/dev/deploy/monitor/deploy.mdcontent/docs/dev/reference/CLI/pd-ctl.mdcontent/docs/dev/reference/CLI/pd-recover.md
Comment on lines
+89
to
+90
| wget https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
There was a problem hiding this comment.
Use HTTPS for .sha256 downloads to preserve integrity guarantees.
The checksum files are still fetched via http:// (Line 90, Line 160). This undermines the checksum verification step because the checksum itself can be tampered with in transit.
🔧 Proposed fix
- wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256
+ wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256
...
- wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256
+ wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256Also applies to: 159-160
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@content/docs/6.5/deploy/install/test.md` around lines 89 - 90, The .sha256
checksum downloads use insecure HTTP; update the wget invocations that fetch the
checksum files (e.g., the lines invoking wget
http://download.pingcap.com/...tidb-latest-linux-amd64.sha256 and the other
similar .sha256 wget) to use HTTPS instead so the checksum cannot be tampered
with in transit; locate the wget commands that reference ".sha256" (the checksum
download commands) and replace "http://" with "https://" for each occurrence.
| wget https://download.pingcap.org/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.org/tidb-latest-linux-amd64.sha256 | ||
| wget https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
There was a problem hiding this comment.
Use HTTPS for checksum downloads to preserve integrity guarantees.
The .sha256 files are still fetched over plain HTTP. If the checksum file can be modified in transit, sha256sum -c no longer provides trustworthy verification.
🔧 Proposed fix
- wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256
+ wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256
...
- wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256
+ wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256Also applies to: 160-160
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@content/docs/dev/deploy/install/test.md` at line 90, Replace the insecure
HTTP checksum download command so it uses HTTPS: update the wget invocation that
fetches "tidb-latest-linux-amd64.sha256" (and the other occurrence around the
same block) to use https://download.pingcap.com/tidb-latest-linux-amd64.sha256
instead of http:// so the sha256 checksum file is fetched over TLS and cannot be
modified in transit.
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
wuhuizuo
force-pushed
the
fix/update-pingcap-domains-master
branch
from
7856116 to
37887ac
Compare
wuhuizuo
commented
Apr 7, 2026
| wget https://download.pingcap.org/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.org/tidb-latest-linux-amd64.sha256 | ||
| wget https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
Author
There was a problem hiding this comment.
Suggested change
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 | |
| wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
wuhuizuo
commented
Apr 7, 2026
| wget https://download.pingcap.org/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.org/tidb-latest-linux-amd64.sha256 | ||
| wget https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
Author
There was a problem hiding this comment.
Suggested change
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 | |
| wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
wuhuizuo
commented
Apr 7, 2026
| wget https://download.pingcap.org/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.org/tidb-latest-linux-amd64.sha256 | ||
| wget https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
Author
There was a problem hiding this comment.
Suggested change
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 | |
| wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
wuhuizuo
commented
Apr 7, 2026
| wget https://download.pingcap.org/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.org/tidb-latest-linux-amd64.sha256 | ||
| wget https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
Author
There was a problem hiding this comment.
Suggested change
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 | |
| wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
wuhuizuo
commented
Apr 7, 2026
| wget https://download.pingcap.org/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.org/tidb-latest-linux-amd64.sha256 | ||
| wget https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
Author
There was a problem hiding this comment.
Suggested change
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 | |
| wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
wuhuizuo
commented
Apr 7, 2026
| wget https://download.pingcap.org/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.org/tidb-latest-linux-amd64.sha256 | ||
| wget https://download.pingcap.com/tidb-latest-linux-amd64.tar.gz | ||
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
Author
There was a problem hiding this comment.
Suggested change
| wget http://download.pingcap.com/tidb-latest-linux-amd64.sha256 | |
| wget https://download.pingcap.com/tidb-latest-linux-amd64.sha256 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
download.pingcap.orgreferences withdownload.pingcap.comcharts.pingcap.orgreferences withcharts.pingcap.comValidation
git diff --checkdownload.pingcap.org/charts.pingcap.orgreferences in the patched branchSummary by CodeRabbit