Skip to content

Update building properties to use _ separator #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarianski merged 1 commit into from
May 10, 2016
Merged

Update building properties to use _ separator #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
v0.10.1
-------
* Update building transforms to work with `_` separated properties. The queries upstream changed to return `_` as the separator instead of `:`. See [#806](https://github.com/mapzen/vector-datasource/issues/806).

v0.10.0
------
-------
* Add `is_bicycle_related` transform. See [#152](https://github.com/mapzen/TileStache/pull/152).
* Normalize cycling related properties so shared properties for `cycleway:left` and `cycleway:right` are deleted and projected into `cycleway` directly, and if `cycleway:both` is included but `cycleway` is not, project that onto `cycleway`. [#150](https://github.com/mapzen/TileStache/pull/150).
* Don't label generate label placements for unnamed stone and rock features. See [#151](https://github.com/mapzen/TileStache/pull/151).
Expand Down
8 changes: 4 additions & 4 deletions TileStache/Goodies/VecTiles/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ def remove_feature_id(shape, properties, fid, zoom):

def building_height(shape, properties, fid, zoom):
height = _building_calc_height(
properties.get('height'), properties.get('building:levels'),
properties.get('height'), properties.get('building_levels'),
_building_calc_levels)
if height is not None:
properties['height'] = height
Expand All @@ -173,7 +173,7 @@ def building_height(shape, properties, fid, zoom):

def building_min_height(shape, properties, fid, zoom):
min_height = _building_calc_height(
properties.get('min_height'), properties.get('building:min_levels'),
properties.get('min_height'), properties.get('building_min_levels'),
_building_calc_min_levels)
if min_height is not None:
properties['min_height'] = min_height
Expand All @@ -193,8 +193,8 @@ def synthesize_volume(shape, props, fid, zoom):
def building_trim_properties(shape, properties, fid, zoom):
properties = _remove_properties(
properties,
'building', 'building:part',
'building:levels', 'building:min_levels')
'building', 'building_part',
'building_levels', 'building_min_levels')
return shape, properties, fid


Expand Down