Skip to content

Update label feature generation behavior #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmarianski merged 2 commits into from
Oct 3, 2015
Merged

Update label feature generation behavior #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9716e26
Only include labels with name or sport tags
rmarianski Oct 3, 2015
5102535
Use representative_point instead of centroid
rmarianski Oct 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions TileStache/Goodies/VecTiles/transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,13 +1483,21 @@ def generate_label_features(
if shape.geom_type not in ('Polygon', 'MultiPolygon'):
continue

# shapely also has a function `representative_point` which we
# might want to consider using here
label_centroid = shape.centroid
# Additionally, the feature needs to have a name or a sport
# tag, oherwise it's not really useful for labelling purposes
name = properties.get('name')
if not name:
sport = properties.get('sport')
if not sport:
continue

label_point = shape.representative_point()

label_properties = properties.copy()
if label_property_name:
label_properties[label_property_name] = label_property_value
label_feature = label_centroid, label_properties, fid

label_feature = label_point, label_properties, fid

# if we're adding these features to a new layer, don't add the
# original features
Expand Down