Drop Python 2 support #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarianski
approved these changes
Dec 15, 2022
Member
rmarianski
left a comment
rmarianski
left a comment
There was a problem hiding this comment.
I like the idea of moving this forward to only support python 3 at this point. @kevinkreiser @nvkelso @peitili @zerebubuth @iandees any objections?
rmarianski
approved these changes
Dec 19, 2022
| @@ -1,3 +1,10 @@ | |||
| Version 1.3.0 | |||
Member
There was a problem hiding this comment.
might warrant a major version bump
Member
There was a problem hiding this comment.
I went ahead and merged this in, made a separate follow up pr for this: #118 @benoit9126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vincentsarago First part of #114
I only dropped the support of Python 2. As the
compatfile was useless, I also dropped it.