[Bug] RetryOperation does not free errors correctly, causing "forever" operations to leak memory

[atondelier]

Hi,

It appears to me that the following splice call

      // retry forever, only keep last error
      this._errors.splice(this._errors.length - 1, this._errors.length);

is not doing what it says it does. It actually only removes the last element of _errors.

Since it has been there for 3 years and nobody complaining about it, I prefer checking with you before if:

• this is an intended behavior
• splicing with a length of the length of the Array was expected to splice at the head of the Array
• or if I'm just completely wrong

Thanks for the great work.

[kiwialec]

We tracked a massive memory leak to this this issue (although the root cause was bad coding on our end). Appreciate this lib might not be maintained anymore, but posting in case it helps with anyone.

• a long running operation (we expected it to retry for days before completing) slowly filled the memory with promises and failed states
• In another process, instead of using bail(), the code just immediately returned false if an external 'finished' condition was true. The retries would slowly fill memory and cause the server to become unresponsive

Switching to another library (exponential-backoff) immediately improved things