Conversation
szygendab
approved these changes
Aug 14, 2024
Contributor
szygendab
left a comment
szygendab
left a comment
There was a problem hiding this comment.
nice!
AFAIR we always had to publish this package manually. We could also think of having a dedicated prod branch to generate release notes for us automatically.
Flexicon
deleted the
Mike-Repec/CLK-481423/Define-CD-pipelines-for-library-publishing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub docs suggest a simple workflow of publishing new packages based on new releases - this way we should be able to make any necessary changes, merge them to the trunk and then release whenever we're ready by generating a new release in the UI.
💡 Our
npm publishcommand already runs tests and lints the source code before building.