Conversation
DialecticConfig 9개 필드 → 4개로 축소 (model, language, exclude_patterns, strategies). context_files, false_positive_files, false_positive_patterns, framework_specific, conventions 필드 및 관련 타입(FrameworkSpecificConfig, ConventionsConfig, ProjectRules) 제거. 새 convention-based 자동 감지 도입: - CLAUDE.md → 프로젝트 컨텍스트 자동 로드 - .github/review-guardrails.json → FP 패턴 + disabled 목록 자동 로드 ProjectRulesLoader를 파일 I/O 없는 순수 함수로 단순화. deprecated 필드 사용 시 경고 출력. 스키마/기본설정/CLI init 템플릿 동기화.
- Rename files: config, workflow, template, schema (git mv × 4) - Rename types: DialecticConfig → LongblackConfig, DialecticError → LongblackError - Replace all string references: package name, repo URLs, display names, author - Update README with convention-over-config approach (remove deprecated fields) - Rebuild dist/action bundle
- Claude Adapter: remove sendMessage, sendMessageStream, validateApiKey,
getCodeReviewSchema, hardcoded pricing, cost calculation
- GitHub Adapter: remove getFileContent, checkRateLimit
- Strategy Selector: remove setCustomStrategy, getStrategyDescription, getAllStrategies
- Types: remove CodeReviewSchema, extended thinking fields (enableThinking,
thinkingBudget, thinking)
- Tests: remove 4 test cases for deleted strategy selector methods
- Revert longblack-pr-review naming back to dialectic-pr for consistency (repo name is immutable due to Marketplace listing) - Restore original type names: DialecticConfig, DialecticError - Restore original file names: dialectic-pr.json, dialectic-pr-schema.json - Remove unused methods: sendMessage, sendMessageStream, validateApiKey, getCodeReviewSchema, getFileContent, checkRateLimit, setCustomStrategy, getStrategyDescription, getAllStrategies - Remove dead code: extended thinking, hardcoded pricing, CodeReviewSchema - Keep README improvements: convention-over-config, auto-detection docs Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.