Skip to content

Conversation

@VineethReddy02
Copy link
Contributor

Description

Livesync for S3 docs

Links

Fixes #[insert issue link, if any]

Writing help

For information about style and word usage, see the Contribution guide

Review checklists

Reviewers: use this section to ensure you have checked everything before approving this PR:

Subject matter expert (SME) review checklist

  • Is the content technically accurate?
  • Is the content complete?
  • Is the content presented in a logical order?
  • Does the content use appropriate names for features and products?
  • Does the content provide relevant links to further information?

Documentation team review checklist

  • Is the content free from typos?
  • Does the content use plain English?
  • Does the content contain clear sections for concepts, tasks, and references?
  • Have any images been uploaded to the correct location, and are resolvable?
  • If the page index was updated, are redirects required
    and have they been implemented?
  • Have you checked the built version of this content?

@github-actions
Copy link

Allow 10 minutes from last push for the staging site to build. If the link doesn't work, try using incognito mode instead. For internal reviewers, check web-documentation repo actions for staging build status. Link to build for this PR: http://docs-dev.timescale.com/docs-vineeth-add-ls-s3-docs

@billy-the-fish billy-the-fish requested a review from atovpeko April 23, 2025 15:12
- Access credentials for the S3 bucket.
- The user needs the following permissions: `s3:GetObject`, `s3:ListBucket`.
- The following credentials are supported:
- [IAM Role][credentials-iam].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This must link to specific instructions. Users need to know which role they need to authorize.

This is already in our UI, Maybe we should have a dedicated page in the documentation as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having the link to these instructions in the UI and a link to the docs is enough. We only rewrite things for other products when the docs are terrible.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not about rewriting docs, There is a process specific for our setup that it is not in AWS docs.

I'm talking about this instructions in the UI
image

user needs to know

  • The role we use is "arn:aws:iam::142548018081:role/timescale-s3-connections"
  • We need permissions to "s3:GetObject","s3:ListBucket"
  • We will send ExternalID with ProjectID/ServiceID

This is not available in AWS docs because it is specific for our setup

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

Copy link
Contributor

@atovpeko atovpeko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atovpeko atovpeko self-requested a review April 24, 2025 12:29
billy-the-fish and others added 3 commits April 24, 2025 14:33
Co-authored-by: Anastasiia Tovpeko <114177030+atovpeko@users.noreply.github.com>
Signed-off-by: Iain Cox <iain@timescale.com>
@billy-the-fish billy-the-fish merged commit c902b44 into latest Apr 24, 2025
3 checks passed
@billy-the-fish billy-the-fish deleted the vineeth-add-ls-s3-docs branch April 24, 2025 12:41
billy-the-fish added a commit that referenced this pull request May 6, 2025
* Add Livesync for S3 docs


Co-authored-by: Iain <iain@timescale.com>
Co-authored-by: Anastasiia Tovpeko <114177030+atovpeko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants