feat: add BEM radiation coupling via bempp-cl#65
Merged
Conversation
Replace the constant plane-wave Robin BC (Z=rho*c) with analytical piston radiation impedance models that vary with frequency. This is more physically accurate for ka < 1 where the current BC over-estimates radiation efficiency. New --radiation-model flag (plane_wave|flanged_piston|unflanged_piston) defaults to plane_wave for backward compatibility. Closes #34 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add nonlocal BEM radiation boundary condition as an alternative to the local Robin BC at the horn mouth. Uses bempp-cl with Numba fallback (no OpenCL required) to couple FEniCSx interior FEM with exterior BEM via iterative Dirichlet-to-Neumann scheme. - New bem_coupling.py module: trace extraction, operator assembly, coupled solver - Solver accepts radiation_model="bem" alongside existing analytical models - Dockerfile installs bempp-cl; main.nf documents new option - Phase 1 scripts: environment gate + FEM-BEM coupling smoke test - Phase 3 scripts: multi-model comparison with overlay plots - Unit tests: import, operators, pulsating sphere, trace extraction, e2e - Validation tests: straight tube + conical horn BEM vs analytical Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
timini
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
radiation_model="bem"option alongside existingplane_wave,flanged_piston,unflanged_pistonChanges
New files:
bem_coupling.py— core BEM coupling module (trace extraction, operator assembly, coupled solver, far-field computation)test_bem_coupling.py— unit tests (import, operators, pulsating sphere vs analytical, trace extraction, e2e)test_bem_vs_analytical.py— validation tests (V7a/b/c: straight tube + conical horn BEM vs analytical)scripts/test_bempp_install.py— Phase 1a environment gatescripts/test_fem_bem_coupling.py— Phase 1b FEM-BEM coupling smoke testscripts/compare_radiation_models.py— Phase 3 multi-model comparison with overlay plotsModified files:
solver.py— routes to coupled BEM solver whenradiation_model="bem", skips Robin BCDockerfile— addspip install bempp-clmain.nf— documentsbemas valid radiation modelTest plan
docker run dolfinx/dolfinx:v0.8.0 bash -c "pip install bempp-cl && python3 scripts/test_bempp_install.py"succeedspytest test_bem_coupling.py— pulsating sphere within 1 dB of analyticalBEMPP_AVAILABLEguard)🤖 Generated with Claude Code