Map 'meta' => 91, move 'command' to aliases #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since browsers generify the ‘command’ and ‘windows’ keys to both be called ‘metaKey’ on event objects, it seems appropriate to do that here too and have ‘command’ and ‘windows’ be aliases. Also expose a ‘_canonicalCodes’ object and test it for duplicates as a sanity check.
Owner
|
@greim sorry took me a while to get back to this. I think this change makes sense, but does need a major version bump. We could wait for a few more features then do a 3.0.0 release or just do a 3.0.0 release with only this one change. What do you think? |
Collaborator
Author
|
Might be good to wait a bit and see if any other changes come to light. I'll definitely comment back here if it becomes an issue for me in the meantime. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize this is a compat break but if a major version is being bumped (#16 (comment)) maybe this would be a good time to add it?
Since browsers generify the ‘command’ and ‘windows’ keys to both be called ‘metaKey’ on event objects, it seems appropriate to do that here too and have ‘command’ and ‘windows’ be aliases. Also expose a ‘_canonicalCodes’ object and test it for duplicates as a sanity check.