Skip to content

fix(frontend): Add flag to check auto-redirect #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
contre95 wants to merge 1 commit into from
Closed

fix(frontend): Add flag to check auto-redirect #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions frontend/src/pages/login-page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ export const LoginPage = () => {

const redirectTimer = useRef<number | null>(null);
const redirectButtonTimer = useRef<number | null>(null);
const hasAutoRedirected = useRef(false);

const searchParams = new URLSearchParams(search);
const {
Expand Down Expand Up @@ -79,6 +80,7 @@ export const LoginPage = () => {
},
onError: () => {
setOauthAutoRedirectHandover(false);
hasAutoRedirected.current = false;
toast.error(t("loginOauthFailTitle"), {
description: t("loginOauthFailSubtitle"),
});
Expand Down Expand Up @@ -122,10 +124,12 @@ export const LoginPage = () => {

useEffect(() => {
if (
!hasAutoRedirected.current &&
providers.find((provider) => provider.id === oauthAutoRedirect) &&
!isLoggedIn &&
props.redirect_uri !== ""
) {
hasAutoRedirected.current = true;
// Not sure of a better way to do this
// eslint-disable-next-line react-hooks/set-state-in-effect
setOauthAutoRedirectHandover(true);
Expand All @@ -139,7 +143,7 @@ export const LoginPage = () => {
isLoggedIn,
props.redirect_uri,
oauthAutoRedirect,
oauthMutation,
oauthMutation.mutate, // stable reference per TanStack Query
]);

useEffect(
Expand Down Expand Up @@ -233,7 +237,7 @@ export const LoginPage = () => {
loading={loginMutation.isPending || oauthMutation.isPending}
/>
)}
{providers.length == 0 && (
{providers.length === 0 && (
<p className="text-center text-red-600 max-w-sm">
{t("failedToFetchProvidersTitle")}
</p>
Expand Down