Initial JSON support #1741
Merged
Initial JSON support #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They both reversed the direction of the check, in a way that mostly cancelled each other out. Of course they're still mostly unimplemented, but it's better if they're not wrong.
This is important as golden test output and to verify that the output is correct. Later improvements and bug fixes are clearly visible in the IR, and unintentional changes will also be immediately spotted.
This is required for correctly differentiating between interface types.
This commit adds a new transform that converts reflect Implements() calls to runtime.interfaceImplements. At the moment, the Implements() method is not yet implemented (how ironic) but if the value passed to Implements is known at compile time the method call can be optimized to runtime.interfaceImplements to make it a regular interface assert. This commit is the last change necessary to add basic support for the encoding/json package. The json package is certainly not yet fully supported, but some trivial objects can be converted to JSON.
Member
|
Still much to be done, but a most impressive step forward, and with the unit tests to prove it. Good work @aykevl Now merging. |
|
Does tinygo support the use of encoding/json for unmarshalling json formatted data into the basic go types (besides custom structs) now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds initial support for the encoding/json package. It is far from complete (structs don't work yet, for example) but it seems to actually work for encoding some trivial types.