fix(ci): correct sentry-cli download URL and trap scope

[senamakel]

The "Upload Tauri shell debug symbols to Sentry" step in release-staging.yml failed with:

/home/runner/.cargo/bin/sentry-cli: line 1: Not: command not found
…
scripts/upload_sentry_symbols.sh: line 1: tmp_dir: unbound variable
Error: Process completed with exit code 1.

Two latent bugs in scripts/upload_sentry_symbols.sh:

1. Wrong asset name

getsentry/sentry-cli releases publish:

• sentry-cli-Linux-x86_64 / sentry-cli-Linux-aarch64 (capital L)
• sentry-cli-Darwin-universal (one universal binary, no per-arch)
• sentry-cli-Windows-x86_64.exe

The script asked for sentry-cli-linux-x86_64 (lowercase). With no --fail on curl, the 404 returned GitHub's HTML "Not Found" page, the script chmod +x'd it, and the next invocation tried to execute the first line as a command — "Not: command not found".

Fixes:

• Use the title-cased OS segment (Linux / Darwin-universal / Windows-x86_64.exe).
• Add curl --fail --silent --show-error --location so 404s become exit-1 instead of silently writing HTML.
• Defence-in-depth: refuse to install a zero-byte download or one whose first bytes are < (HTML page).

2. tmp_dir: unbound variable on cleanup

The cleanup trap was wired with EXIT but tmp_dir was declared local inside ensure_sentry_cli. By the time EXIT fires, the function has returned and set -u errors. Moved to RETURN so the trap runs in the function's scope while tmp_dir is still defined.

Test plan

• Re-trigger Release (Staging) after merge and confirm Upload Tauri shell debug symbols to Sentry succeeds end-to-end on the linux runner.
• Confirm the same step succeeds on the macOS matrix entries (Darwin-universal asset).
• Spot-check that the uploaded DIFs land in the openhuman-tauri Sentry project under openhuman@<version>+<short_sha>.

Summary by CodeRabbit

• Bug Fixes
  • Improved symbol upload reliability with enhanced validation and error handling across different operating systems and architectures.
  • Strengthened download verification to ensure file integrity before processing.
  • Improved logging for better transparency during the upload process.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 139860ba-9850-4f31-b211-3a3bb69c626a

📥 Commits

Reviewing files that changed from the base of the PR and between 4134e68 and 09f5d53.

📒 Files selected for processing (1)

• scripts/upload_sentry_symbols.sh

---

📝 Walkthrough

Walkthrough

The sentry-cli download installation in scripts/upload_sentry_symbols.sh now uses Sentry's official OS/architecture asset naming (e.g., Linux-x86_64, Darwin-universal), implements function-scoped temp directory cleanup via a RETURN trap, and hardens the download with strict error checking and HTTP response validation.

Changes

Sentry CLI Installation Hardening

Layer / File(s)	Summary
Asset Naming scripts/upload_sentry_symbols.sh (lines 73–101)	Architecture detection maps to Sentry's published asset identifiers: Linux-x86_64, Linux-aarch64, Darwin-universal, Windows-x86_64.exe instead of prior lowercase/per-arch variants.
Temp Directory Management scripts/upload_sentry_symbols.sh (lines 112–120)	Function-scoped local tmp_dir is cleaned up via a RETURN trap, avoiding set -u issues and ensuring proper scope isolation.
Download Validation & Hardening scripts/upload_sentry_symbols.sh (lines 121–150)	curl uses --fail flag, wget uses stricter options, and the downloaded artifact is validated for non-empty content and absence of HTML response headers (< check).
Logging scripts/upload_sentry_symbols.sh	Error messages and download status logging expanded throughout the installation workflow.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix(devops): upload Rust debug symbols to Sentry during Tauri build #890: Modifies the same scripts/upload_sentry_symbols.sh script and ensure_sentry_cli function, including sentry-cli download and installation logic.

Poem

🐰 With Sentry's true names now in place,
Traps catch the temp files with grace,
curl checks for errors, no HTML surprise,
A script more robust, with vigilant eyes! ✨

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 1/5 review remaining, refill in 47 minutes and 42 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}