fix(ui): move Intelligence and Webhooks to Developer Options, clean up nav#1225
Conversation
…p nav Move /intelligence and /webhooks from top-level routes into the Developer Options settings section. Remove the Memory tab from the bottom tab bar. Old routes redirect to their new settings paths. Update keyboard shortcut, deep links, and E2E tests accordingly. Closes tinyhumansai#1216
📝 WalkthroughWalkthroughThe PR relocates Intelligence and Webhooks pages from top-level routes ( ChangesNavigation Refactor: Move Intelligence & Webhooks to Settings/Developer Options
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/openhuman/notifications/bus.rs (1)
106-106: ⚡ Quick winAdd a Rust-side assertion for the new webhook deep link.
Since this line changes the canonical translation target, it’s worth asserting
deep_linkinfailed_webhook_produces_system_notificationso route regressions are caught at the source layer too.Proposed test assertion
let n = event_to_notification(&ev).unwrap(); assert_eq!(n.category, CoreNotificationCategory::System); assert!(n.body.contains("skill-x")); assert!(n.body.contains("boom")); + assert_eq!(n.deep_link.as_deref(), Some("/settings/webhooks-triggers"));🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/openhuman/notifications/bus.rs` at line 106, Add an assertion in the Rust test failed_webhook_produces_system_notification to verify the notification's deep_link field matches the new canonical route ("/settings/webhooks-triggers"); locate where the test constructs or inspects the produced system notification and assert that notification.deep_link == Some("/settings/webhooks-triggers".into()) (or equivalent) so route regressions are caught at the source layer.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/openhuman/notifications/bus.rs`:
- Line 106: Add an assertion in the Rust test
failed_webhook_produces_system_notification to verify the notification's
deep_link field matches the new canonical route ("/settings/webhooks-triggers");
locate where the test constructs or inspects the produced system notification
and assert that notification.deep_link ==
Some("/settings/webhooks-triggers".into()) (or equivalent) so route regressions
are caught at the source layer.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2ecf22b1-ddd8-4776-b59d-afa03f281d86
📒 Files selected for processing (11)
app/src/AppRoutes.tsxapp/src/components/BottomTabBar.tsxapp/src/components/settings/hooks/useSettingsNavigation.tsapp/src/components/settings/panels/DeveloperOptionsPanel.tsxapp/src/lib/commands/globalActions.tsapp/src/lib/nativeNotifications/__tests__/service.test.tsapp/src/pages/Settings.tsxapp/test/e2e/helpers/shared-flows.tsapp/test/e2e/specs/insights-dashboard.spec.tsapp/test/e2e/specs/webhooks-tunnel-flow.spec.tssrc/openhuman/notifications/bus.rs
💤 Files with no reviewable changes (1)
- app/src/components/BottomTabBar.tsx
Summary
/intelligenceand/webhooksfrom top-level routes into the Developer Options settings section/intelligence,/webhooks) redirect to their new settings pathsChanges
AppRoutes.tsx<Navigate>redirectsBottomTabBar.tsxDeveloperOptionsPanel.tsxSettings.tsxuseSettingsNavigation.tsglobalActions.tsnotifications/bus.rsTest plan
/intelligenceURL redirects to/settings/intelligence/webhooksURL redirects to/settings/webhooks-triggersCloses #1216
Summary by CodeRabbit
Navigation Changes
Developer Options