fix(tauri): disable Linux CEF GPU startup path#1807
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughRefactors CEF GPU startup command-line workarounds into a reusable helper. Adds ChangesCEF GPU Workaround Helper Refactoring
🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs:
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolve conflict in app/src-tauri/src/lib.rs by keeping the append_platform_cef_gpu_workarounds() helper (this PR) and dropping the inline #[cfg]-gated blocks that landed via tinyhumansai#1809. The helper already covers issue tinyhumansai#1697 (Linux --disable-gpu + --disable-gpu-compositing) and issue tinyhumansai#1012 (Intel macOS --disable-gpu-compositing), and is exercised by the new unit tests. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Heads-up for reviewers: the two failing checks (
Specifically:
Happy to rebase once |
Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Summary
Validation
Notes
The reported AppImage failures on Manjaro/Arch show CEF/Chromium failing to create EGL GPU contexts before launch completes. For packaged Linux builds, preferring software compositing is a smaller recovery path than touching the bundler or distro-specific runtime dependencies.
Summary by CodeRabbit
Refactor
Tests