feat(memory): add per-model embedding tables#2010
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThis PR implements per-provider/model embedding storage across the memory system by introducing signature-keyed embedding tables in the unified event/segment stores and tree-based chunk/summary stores. Each storage type gains a new embedding table, upsert/fetch APIs, and tests validating isolation by model signature. ChangesPer-provider/model embedding storage
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: honor2030 <19909783+honor2030@users.noreply.github.com>
Summary
This is intended as a small Stage 1 slice for #1574: schema + helper support only. Existing query paths still use the legacy columns until a follow-up PR wires dual-write/query-time model-signature filtering.
Verification
rustup run 1.93.0 cargo fmt --allRUSTC=/Users/lee/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/rustc GGML_NATIVE=OFF rustup run 1.93.0 cargo test --manifest-path Cargo.toml embeddings_are_scoped_by_model_signature --lib -- --nocaptureRUSTC=/Users/lee/.rustup/toolchains/1.93.0-aarch64-apple-darwin/bin/rustc GGML_NATIVE=OFF CARGO_TARGET_DIR=/Users/lee/Documents/Claude/Projects/10\ Work\ OS/projects/openhuman/target rustup run 1.93.0 cargo check --manifest-path Cargo.tomlNote: an initial
cargo checkusing the worktree-local/tmp/.../targetfailed withNo space left on device; rerunning with the already-used local OpenHuman target dir completed successfully.Fixes part of #1574.
Summary by CodeRabbit
New Features
Tests