fix(onboarding): clarify continue to chat fallback#2173
Conversation
📝 WalkthroughWalkthroughThis PR updates the post-login profile build fallback to communicate readiness rather than failure. English translations change from "couldn't build your full profile" to "your chat is ready," the error card is styled with primary-themed colors, and tests are updated to verify both the new messaging and UI presentation. ChangesProfile Build Fallback Messaging & UI
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
graycyrus
left a comment
There was a problem hiding this comment.
Walkthrough
Clean, focused change that reframes the onboarding profile-build fallback from a failure message to a ready-state message, and wraps the CTA in a visually prominent callout panel. Copy, component, and tests are all updated consistently. No logic, security, or architectural concerns.
Change summary
| File | Change | Description |
|---|---|---|
app/src/lib/i18n/chunks/en-4.ts |
copy | Fallback string → chat-ready tone |
app/src/lib/i18n/en.ts |
copy | Same string in main bundle |
app/src/pages/onboarding/steps/ContextGatheringStep.tsx |
UI | Wrap fallback in primary-tinted panel, adjust text color |
app/src/pages/onboarding/steps/__tests__/ContextGatheringStep.test.tsx |
test | Update assertions to match new copy |
Notes
- [minor] Issue #2157 acceptance criteria includes "Optional auto-progress considered — Either auto-progress after a safe delay or document why manual action is preferred." This PR doesn't implement auto-progress or document why it was skipped. Worth a quick comment in the PR description or issue thread explaining the decision (e.g., manual action preferred to avoid surprising users).
Otherwise this looks good — the copy is clearer, the panel draws the eye to the CTA, tests cover both the timeout and error paths, and all CI is green. Nice improvement.
|
Thanks for the review. On the optional auto-progress criterion: I kept this manual because the fallback appears after a profile-build failure/timeout, and auto-navigating from that recovery state could feel surprising or make users miss the context that profile enrichment is still incomplete. Making the CTA prominent keeps the escape hatch obvious while preserving user control. |
graycyrus
left a comment
There was a problem hiding this comment.
Looks good, nice work!
Co-authored-by: Ajay Kumar Reddy Nelavetla <ajay@Ajays-MacBook-Air.local>
Summary
Continue to chatCTA in a focused callout.Problem
Continue to chatis available and safe to use.Solution
Submission Checklist
node_modulesin this checkout and is documented below.## Related— N/A: no coverage-matrix feature ID changed.docs/RELEASE-MANUAL-SMOKE.md) — N/A: narrow onboarding fallback UI copy/prominence change.Closes #NNNin the## RelatedsectionImpact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
codex/obvious-continue-chatd8a98912951ffe8b306a995d15881d7218503483Validation Run
pnpm --filter openhuman-app format:check— not run locally; blocked by missingnode_modules, see below.pnpm typecheck— not run locally; blocked by missingnode_modules, see below.pnpm debug unit app/src/pages/onboarding/steps/__tests__/ContextGatheringStep.test.tsx— attempted locally, blocked by missingnode_modules; CI is running the suite.Validation Blocked
command:pnpm debug unit app/src/pages/onboarding/steps/__tests__/ContextGatheringStep.test.tsxerror:local checkout is missingnode_modules; pnpm reported:Local package.json exists, but node_modules missing, did you mean to install?impact:focused Vitest validation did not run locally in this clone.Behavior Changes
Parity Contract
Continue to chatstill calls the sameonNextpath; only copy and presentation changed.Duplicate / Superseded PR Handling