test(e2e): wipe memory tree during test reset#2308
Conversation
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughThe reset flow now wipes memory-tree persistent data and reports results. ChangesMemory-tree cleanup in test reset
Core process readiness budget
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
48630b4 to
d1fd489
Compare
# Conflicts: # src/openhuman/test_support/rpc.rs
cargo-llvm-cov instrumentation roughly doubles cold-start time for the embedded core. The 10s budget added in tinyhumansai#2116 still flakes the ensure_running_falls_back_to_7789_when_7788_is_busy test on the Tauri coverage runner. 20s gives the readiness probe enough slack without affecting user-visible startup (ready signal lands in <1s on normal runs and the loop exits immediately).
|
merged 🙌 thanks @aqilaziz, love that test_reset now wipes the memory tree too (plus those reset summary fields are gonna make appium logs way easier to debug). always a treat seeing you back in the prs. |
Summary
openhuman.test_resetso E2E resets also wipe Memory Tree state via the existingmemory_tree_wipe_allpath.Problem
openhuman.test_resetonly cleared auth/onboarding/cron state, while Memory Tree data could survive between specs in a shared Appium session.Solution
read_rpc::wipe_all_rpc(&config)fromtest_support::rpc::resetafter cron cleanup and before config/auth clearing.memory_tree_rows_deleted,memory_tree_dirs_removed, andmemory_tree_sync_state_clearedinResetSummary,reset_json, and the controller schema.Submission Checklist
wipe_all_rpcowns table/sync-state failure behavior.## Related— N/A: no feature matrix row.docs/RELEASE-MANUAL-SMOKE.md) — N/A: test-support RPC only.Closes #NNNin the## Relatedsection — N/A: scoped slice; references Expand openhuman.test_reset coverage as more domains are touched by E2E #1862 without closing the umbrella.Impact
resetApp(...)now start without prior Memory Tree chunks, summary/wiki files, or sync cursors.openhuman.test_resetcontroller is compiled/enabled.Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
codex/1862-test-reset-memory-tree48630b40f69400d6a3c5e055e80c25486e3bba6dValidation Run
pnpm --filter openhuman-app format:check— N/A: no frontend files changed.pnpm typecheck— N/A: no TypeScript files changed.cargo test -p openhuman test_support::rpc::tests::wipe_memory_tree_removes_content_dirs_and_reports_summary --lib.cargo fmt --all --check;git diff --check.Validation Blocked
command:cargo test -p openhuman test_support::rpc::tests::wipe_memory_tree_removes_content_dirs_and_reports_summary --liberror:local Windows build fails before tests inwhisper-rs-sysbecauseclang.dll/libclang.dllis missing andLIBCLANG_PATHis unset.impact:focused test did not execute locally; CI Linux/Windows runners with libclang are expected to compile and run it.Behavior Changes
Parity Contract
wipe_all_rpcimplementation instead of adding a second deletion path.Duplicate / Superseded PR Handling
Summary by CodeRabbit
New Features
Documentation
Tests
Bug Fixes