Skip to content

fix(i18n): complete German MCP translations#2470

Closed
YOMXXX wants to merge 2 commits into
tinyhumansai:mainfrom
YOMXXX:fix/german-i18n-mcp-keys
Closed

fix(i18n): complete German MCP translations#2470
YOMXXX wants to merge 2 commits into
tinyhumansai:mainfrom
YOMXXX:fix/german-i18n-mcp-keys

Conversation

@YOMXXX
Copy link
Copy Markdown
Contributor

@YOMXXX YOMXXX commented May 22, 2026

Summary

  • Add missing German translations for the subconscious provider status labels.
  • Add missing German translations for the MCP Server settings panel and developer menu entry.
  • Restore German locale key parity with English so i18n checks and frontend i18n tests pass.

Problem

  • upstream/main currently has German locale support but is missing 20 English keys.
  • This fails pnpm i18n:check and the frontend i18n unit tests.
  • The same main-side i18n gap is also blocking PR feat(mcp): add memory.store and memory.note write tools #2306 because its CI merge ref includes the latest main locale set.

Solution

  • Added the two missing subconscious.* keys to de-3.ts.
  • Added the 18 missing settings.*mcpServer* keys to de-5.ts.
  • Kept the change limited to German translation chunks; no runtime behavior changes.

Submission Checklist

  • Tests added or updated (happy path + at least one failure / edge case) per Testing Strategy: N/A, existing i18n parity tests covered the missing-key failure.
  • Diff coverage ≥ 80% — N/A, translation-only change covered by existing i18n checks/tests; no executable logic changed.
  • Coverage matrix updated — N/A: translation-only change.
  • All affected feature IDs from the matrix are listed in the PR description under ## Related: N/A, no feature matrix row affected.
  • No new external network dependencies introduced (mock backend used per Testing Strategy)
  • Manual smoke checklist updated if this touches release-cut surfaces (docs/RELEASE-MANUAL-SMOKE.md): N/A, no release smoke surface changed.
  • Linked issue closed via Closes #NNN in the ## Related section: N/A, no dedicated issue found.

Impact

  • Desktop/web UI: German locale now has the same translation key coverage as English.
  • No performance, security, migration, or compatibility impact.

Related


AI Authored PR Metadata (required for Codex/Linear PRs)

Linear Issue

  • Key: N/A
  • URL: N/A

Commit & Branch

  • Branch: fix/german-i18n-mcp-keys
  • Commit SHA: 01d004dc

Validation Run

  • pnpm --filter openhuman-app format:check
  • pnpm typecheck
  • Focused tests: pnpm i18n:check; pnpm --filter openhuman-app test:unit src/lib/i18n/__tests__/coverage.test.ts src/lib/i18n/__tests__/I18nContext.test.tsx
  • Rust fmt/check (if changed): GGML_NATIVE=OFF pnpm rust:check passed; Rust code unchanged.
  • Tauri fmt/check (if changed): covered by GGML_NATIVE=OFF pnpm rust:check; Tauri code unchanged.

Validation Blocked

  • command: git push -u origin fix/german-i18n-mcp-keys standard pre-push hook
  • error: local macOS/Apple Silicon whisper-rs-sys build failed with unsupported argument 'native' to option '-mcpu='
  • impact: known local environment issue documented in AGENTS.md; reran with GGML_NATIVE=OFF pnpm rust:check successfully, then pushed with --no-verify.

Behavior Changes

  • Intended behavior change: German locale now resolves the added MCP Server and subconscious provider labels.
  • User-visible effect: German users no longer fall back/miss those labels.

Parity Contract

  • Legacy behavior preserved: all non-German locale maps unchanged.
  • Guard/fallback/dispatch parity checks: existing i18n parity tests pass.

Duplicate / Superseded PR Handling

  • Duplicate PR(s): None found.
  • Canonical PR: This PR.
  • Resolution (closed/superseded/updated): N/A.

Summary by CodeRabbit

  • Localization
    • Added German translations for subconscious provider unavailability and AI settings interfaces.
    • Added German translations for MCP server configuration UI, including tool sections, client configuration options, and error messaging.

Review Change Stack

@YOMXXX YOMXXX requested a review from a team May 22, 2026 00:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b6b5ff32-52d0-4798-bc69-2ea202abeae7

📥 Commits

Reviewing files that changed from the base of the PR and between 7fe3dd0 and 01d004d.

📒 Files selected for processing (2)
  • app/src/lib/i18n/chunks/de-3.ts
  • app/src/lib/i18n/chunks/de-5.ts

📝 Walkthrough

Walkthrough

German translation entries are added to the i18n chunk system for two feature areas. Subconscious provider status labels are added to de-3. MCP server configuration UI strings—including server description, tool and configuration section headers, clipboard feedback, file operation messages, supported client display names, and accessibility labels—are added to de-5.

Changes

German i18n Translations Update

Layer / File(s) Summary
Subconscious and MCP Server translations
app/src/lib/i18n/chunks/de-3.ts, app/src/lib/i18n/chunks/de-5.ts
German translations added for subconscious provider unavailability title and settings label in de-3. MCP server configuration UI strings—including server metadata, tool and settings section headers, copy/clipboard feedback, configuration file messages, supported MCP client display names, and client selector aria label—added to de-5.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • tinyhumansai/openhuman#2378: Continues German-locale translation work for the i18n chunk system with new translation keys for feature-specific UI strings.

Suggested labels

working

Suggested reviewers

  • graycyrus

Poem

🐰 Translations bloom in German text so fine,
Subconscious whispers, MCP config align,
Strings for tools and servers, labels clear,
More tongues for users drawing near!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(i18n): complete German MCP translations' directly and clearly describes the main change: adding missing German translations for MCP (Message Communication Protocol) functionality, specifically completing translation key parity.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot added the working A PR that is being worked on by the team. label May 22, 2026
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 22, 2026
@YOMXXX
Copy link
Copy Markdown
Contributor Author

YOMXXX commented May 22, 2026

@graycyrus This small i18n parity PR is ready for human review/merge. It fixes the main-side German MCP translation gap that is currently causing the stale frontend/i18n failures on #2306. Latest effective checks are green and CodeRabbit approved. I tried to request review through GitHub, but this account does not have permission to call RequestReviewsByLogin, so tagging here.

@M3gA-Mind
Copy link
Copy Markdown
Contributor

@YOMXXX this PR has merge conflicts with main — please rebase/resolve before review.

…-keys

# Conflicts:
#	app/src/lib/i18n/chunks/de-5.ts
@YOMXXX
Copy link
Copy Markdown
Contributor Author

YOMXXX commented May 22, 2026

@M3gA-Mind @graycyrus Ready for review again.

Latest state on 0d7a2a5:

  • merge conflicts are resolved
  • all CI checks are green
  • no active unresolved review threads

@M3gA-Mind
Copy link
Copy Markdown
Contributor

Hey @YOMXXX — thanks so much for the contribution! 🙏

The German i18n fixes were actually already applied in a prior commit (726f6c1 / 0defb51), so your PR no longer carries any net diff against main. To avoid merging a no-op, I'm going to close this one out.

Really appreciate you taking the time to submit a fix — please don't let this discourage you from contributing again!

@M3gA-Mind M3gA-Mind closed this May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

working A PR that is being worked on by the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants