fix(i18n): complete German MCP translations#2470
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughGerman translation entries are added to the i18n chunk system for two feature areas. Subconscious provider status labels are added to ChangesGerman i18n Translations Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@graycyrus This small i18n parity PR is ready for human review/merge. It fixes the main-side German MCP translation gap that is currently causing the stale frontend/i18n failures on #2306. Latest effective checks are green and CodeRabbit approved. I tried to request review through GitHub, but this account does not have permission to call RequestReviewsByLogin, so tagging here. |
|
@YOMXXX this PR has merge conflicts with main — please rebase/resolve before review. |
…-keys # Conflicts: # app/src/lib/i18n/chunks/de-5.ts
|
@M3gA-Mind @graycyrus Ready for review again. Latest state on
|
|
Hey @YOMXXX — thanks so much for the contribution! 🙏 The German i18n fixes were actually already applied in a prior commit (726f6c1 / 0defb51), so your PR no longer carries any net diff against Really appreciate you taking the time to submit a fix — please don't let this discourage you from contributing again! |
Summary
Problem
upstream/maincurrently has German locale support but is missing 20 English keys.pnpm i18n:checkand the frontend i18n unit tests.Solution
subconscious.*keys tode-3.ts.settings.*mcpServer*keys tode-5.ts.Submission Checklist
## Related: N/A, no feature matrix row affected.docs/RELEASE-MANUAL-SMOKE.md): N/A, no release smoke surface changed.Closes #NNNin the## Relatedsection: N/A, no dedicated issue found.Impact
Related
AI Authored PR Metadata (required for Codex/Linear PRs)
Linear Issue
Commit & Branch
fix/german-i18n-mcp-keys01d004dcValidation Run
pnpm --filter openhuman-app format:checkpnpm typecheckpnpm i18n:check;pnpm --filter openhuman-app test:unit src/lib/i18n/__tests__/coverage.test.ts src/lib/i18n/__tests__/I18nContext.test.tsxGGML_NATIVE=OFF pnpm rust:checkpassed; Rust code unchanged.GGML_NATIVE=OFF pnpm rust:check; Tauri code unchanged.Validation Blocked
command:git push -u origin fix/german-i18n-mcp-keysstandard pre-push hookerror:local macOS/Apple Siliconwhisper-rs-sysbuild failed withunsupported argument 'native' to option '-mcpu='impact:known local environment issue documented inAGENTS.md; reran withGGML_NATIVE=OFF pnpm rust:checksuccessfully, then pushed with--no-verify.Behavior Changes
Parity Contract
Duplicate / Superseded PR Handling
Summary by CodeRabbit