fix(voice): auto-select first preset when mascot voice gender changes#2764
Conversation
Switching gender in Mascot settings now immediately updates the voice preset to the first curated preset for that gender, so the picker always reflects a valid selection rather than carrying over a voice from the previous gender.
|
Caution Review failedPull request was closed or merged during review No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughMascotPanel's voice gender change handler now automatically selects the first matching voice preset when the gender filter changes. This updates the voice selection draft, clears any preview errors, disables paste mode, and dispatches state to keep the controlled voice picker synchronized. ChangesMascot voice preset auto-selection
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
Summary
JBFqnCBsd6RMkjVDRZzb)21m00Tcm4TlvDq8ikWAM)Root cause:
onGenderChangeinMascotPanel.tsxonly dispatchedsetMascotVoiceGenderbut never updated the voice ID, leaving the preset dropdown pointing at a voice from the previous gender.Test plan
Summary by CodeRabbit