Skip to content

chore(release): increase Node.js memory limit for builds#838

Merged
M3gA-Mind merged 3 commits into
tinyhumansai:mainfrom
YellowSnnowmann:fix/workflow
Apr 23, 2026
Merged

chore(release): increase Node.js memory limit for builds#838
M3gA-Mind merged 3 commits into
tinyhumansai:mainfrom
YellowSnnowmann:fix/workflow

Conversation

@YellowSnnowmann
Copy link
Copy Markdown
Contributor

@YellowSnnowmann YellowSnnowmann commented Apr 23, 2026

fix(ci): resolve macOS OOM crash and Ubuntu AppImage bundle failure

Problem

Three platforms were failing in the release workflow:

macOS (aarch64 + x86_64) — exit code 134 (OOM)

  • macos-latest runners are now M1 machines (~7GB RAM)
  • NODE_OPTIONS=--max-old-space-size=8192 was requesting 8GB heap on a ~7GB system
  • Result: OS kills the process mid-build (OOM crash)

Additionally:

  • NODE_OPTIONS was only applied to the explicit yarn build step
  • The second Vite build (triggered internally by cargo tauri build via beforeBuildCommand) ran without heap override

Ubuntu — exit code 1 (AppImage missing libraries)

  • The vendored CEF bundler uses quick-sharun to assemble the AppImage
  • quick-sharun runs an ldd check before packaging
  • It aborts if any shared libraries are missing

Problem:

  • CEF runtime libraries (libcef.so, etc.) exist in ~/.cache/tauri-cef
  • But they are NOT available in LD_LIBRARY_PATH during bundling

Result:

  • AppImage build always fails

Fix

Platform Change
macOS Reduced --max-old-space-size from 8192 → 4096 (fits within runner RAM). Added NODE_OPTIONS to the cargo tauri build step so both Vite builds use the same memory limit.
Ubuntu Added --bundles deb to matrix args. This skips AppImage generation entirely and builds only .deb, which works reliably. AppImage can be re-enabled once CEF library resolution is fixed.

Test Plan

  • Trigger release workflow
  • Confirm:
    • Desktop: aarch64-apple-darwin completes without OOM
    • Desktop: x86_64-apple-darwin completes without OOM
  • Confirm:
    • Desktop: ubuntu completes successfully
    • .deb artifact is generated
  • Verify:
    • .deb installs and runs correctly on Ubuntu 22.04
  • Ensure:
    • Desktop: windows build remains unaffected

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

📝 Walkthrough

Walkthrough

The GitHub Actions release workflow updates set NODE_OPTIONS=--max-old-space-size=4096 for frontend and Tauri packaging steps, and adds --bundles deb to the cargo tauri build invocation for the x86_64-unknown-linux-gnu target to produce a .deb bundle.

Changes

Cohort / File(s) Summary
GitHub Actions Workflow
\.github/workflows/release.yml
Set NODE_OPTIONS=--max-old-space-size=4096 in both the standalone frontend yarn build step and the Tauri packaging step; add --bundles deb argument to cargo tauri build for x86_64-unknown-linux-gnu to produce a .deb installer.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A rabbit writes to CI with cheer,
"Give builds more memory, lend an ear—
Four gigs for yarn and Tauri's bake,
A tidy .deb for Linux's sake.
Hop, build, release — delights appear!" 🥕🚀

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title refers to increasing Node.js memory limit, which is only one of two changes in the PR. The commit message reveals a second major change: adding deb bundles for Linux, which is not mentioned in the PR title. Update the title to reflect both changes, such as: 'chore(release): increase Node.js memory and add deb bundles for Linux builds' or focus on the primary change if one is more significant.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@YellowSnnowmann YellowSnnowmann marked this pull request as ready for review April 23, 2026 15:07
@YellowSnnowmann YellowSnnowmann requested a review from a team April 23, 2026 15:07
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/release.yml:
- Line 452: The workflow sets NODE_OPTIONS: --max-old-space-size=8192 which
exceeds macOS runner memory; update the release workflow so NODE_OPTIONS is
reduced or applied conditionally: either lower the value to a safe range (e.g.,
4096–6144) or only set NODE_OPTIONS for non-macOS jobs/runners, and verify the
Tauri step's beforeBuildCommand (npm run build:app && npm run core:stage) still
receives the needed flags or add them inside the package scripts if required;
locate the NODE_OPTIONS entry and the Tauri step (beforeBuildCommand / npm run
build:app) and implement the conditional or value change accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d23f2470-c762-465c-a1b9-f65e0966a87f

📥 Commits

Reviewing files that changed from the base of the PR and between c8ecfd8 and 7f15115.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Comment thread .github/workflows/release.yml Outdated
@Al629176 Al629176 requested a review from graycyrus April 23, 2026 16:08
@M3gA-Mind M3gA-Mind merged commit 06b6890 into tinyhumansai:main Apr 23, 2026
7 checks passed
AusAgentSmith pushed a commit to AusAgentSmith/openhuman that referenced this pull request May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants