chore(release): increase Node.js memory limit for builds#838
Conversation
📝 WalkthroughWalkthroughThe GitHub Actions release workflow updates set Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/release.yml:
- Line 452: The workflow sets NODE_OPTIONS: --max-old-space-size=8192 which
exceeds macOS runner memory; update the release workflow so NODE_OPTIONS is
reduced or applied conditionally: either lower the value to a safe range (e.g.,
4096–6144) or only set NODE_OPTIONS for non-macOS jobs/runners, and verify the
Tauri step's beforeBuildCommand (npm run build:app && npm run core:stage) still
receives the needed flags or add them inside the package scripts if required;
locate the NODE_OPTIONS entry and the Tauri step (beforeBuildCommand / npm run
build:app) and implement the conditional or value change accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: d23f2470-c762-465c-a1b9-f65e0966a87f
📒 Files selected for processing (1)
.github/workflows/release.yml
fix(ci): resolve macOS OOM crash and Ubuntu AppImage bundle failure
Problem
Three platforms were failing in the release workflow:
macOS (aarch64 + x86_64) — exit code 134 (OOM)
Additionally:
yarn buildstepcargo tauri buildviabeforeBuildCommand) ran without heap overrideUbuntu — exit code 1 (AppImage missing libraries)
quick-sharunto assemble the AppImagequick-sharunruns anlddcheck before packagingProblem:
~/.cache/tauri-cefLD_LIBRARY_PATHduring bundlingResult:
Fix
--max-old-space-sizefrom 8192 → 4096 (fits within runner RAM). Added NODE_OPTIONS to thecargo tauri buildstep so both Vite builds use the same memory limit.--bundles debto matrix args. This skips AppImage generation entirely and builds only.deb, which works reliably. AppImage can be re-enabled once CEF library resolution is fixed.Test Plan
.debartifact is generated.debinstalls and runs correctly on Ubuntu 22.04