Skip to content

feat(about_app, settings): capability privacy metadata + panel wiring#858

Closed
jwalin-shah wants to merge 2 commits into
tinyhumansai:mainfrom
jwalin-shah:feat/privacy-capability-metadata
Closed

feat(about_app, settings): capability privacy metadata + panel wiring#858
jwalin-shah wants to merge 2 commits into
tinyhumansai:mainfrom
jwalin-shah:feat/privacy-capability-metadata

Conversation

@jwalin-shah
Copy link
Copy Markdown
Contributor

Drives the Settings privacy panel from about_app capability metadata rather than hard-coded lists — so adding a new capability automatically surfaces its privacy story.

Changes

  • about_app: capability privacy metadata schema + per-capability entries
  • settings: privacy panel reads from about_app capabilities
  • +451 / −3 lines, 8 files

Note

Branch is 58 commits behind main — may need a rebase before merge.

Test plan

  • Settings → Privacy renders full capability list
  • New capability added to about_app shows up without panel code change
  • cargo test -p openhuman_core about_app green

Adds optional `CapabilityPrivacy { leaves_device, data_kind, destinations }`
to the about_app capability catalog so the in-app Privacy surface can be
backend-backed instead of hand-maintained. Twelve representative capabilities
are annotated for the first audited set (raw/local, derived/backend,
credentials, diagnostics, model download); remaining entries default to
None and are simply not surfaced. Wire format stays backward compatible
via skip_serializing_if.
Replaces the hand-maintained privacy rows with data fetched from
openhuman.about_app_list. Only capabilities that ship privacy metadata
are rendered; loading and RPC failure both degrade gracefully and the
analytics toggle plus explanatory copy remain intact. Adds a small typed
client (utils/tauriCommands/aboutApp.ts) and focused vitest coverage for
render, omission of unannotated entries, and RPC failure.
@jwalin-shah jwalin-shah requested a review from a team April 23, 2026 21:27
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

Warning

Rate limit exceeded

@jwalin-shah has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 56 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 18 minutes and 56 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 450abf92-4b1b-4314-b01f-9f52e6d16d54

📥 Commits

Reviewing files that changed from the base of the PR and between 9d7237b and 313e44e.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • app/src/components/settings/panels/PrivacyPanel.tsx
  • app/src/components/settings/panels/__tests__/PrivacyPanel.test.tsx
  • app/src/utils/tauriCommands/aboutApp.ts
  • app/src/utils/tauriCommands/index.ts
  • src/openhuman/about_app/catalog.rs
  • src/openhuman/about_app/mod.rs
  • src/openhuman/about_app/types.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jwalin-shah
Copy link
Copy Markdown
Contributor Author

Superseded by already-merged #760 — both branch commits landed verbatim via squash. Closing.

@jwalin-shah jwalin-shah deleted the feat/privacy-capability-metadata branch April 23, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants