Skip to content

feat: sort watchlist alphabetically #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulvanbrenk merged 1 commit into from
Mar 18, 2026
Merged

feat: sort watchlist alphabetically #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions PatchNotes.Api/Routes/WatchlistRoutes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public static WebApplication MapWatchlistRoutes(this WebApplication app)
var packages = await db.Watchlists
.AsNoTracking()
.Where(w => w.UserId == user.Id)
.OrderBy(w => w.Package.GithubOwner).ThenBy(w => w.Package.GithubRepo)
.Select(w => new WatchlistPackageDto(
w.Package.Id,
w.Package.Name,
Expand Down
32 changes: 21 additions & 11 deletions patchnotes-web/src/pages/WatchlistPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,17 +270,27 @@ export function WatchlistPage() {
</p>
</div>
) : (
(watchlist ?? []).map((pkg) => (
<WatchedPackageItem
key={pkg.id}
pkg={pkg}
onRemove={() => handleRemove(pkg.id)}
isRemoving={
removeFromWatchlist.isPending &&
removeFromWatchlist.variables === pkg.id
}
/>
))
[...(watchlist ?? [])]
.sort((a, b) => {
const nameA = (
a.npmName ?? `${a.githubOwner}/${a.githubRepo}`
).toLowerCase()
const nameB = (
b.npmName ?? `${b.githubOwner}/${b.githubRepo}`
).toLowerCase()
return nameA.localeCompare(nameB)
})
.map((pkg) => (
<WatchedPackageItem
key={pkg.id}
pkg={pkg}
onRemove={() => handleRemove(pkg.id)}
isRemoving={
removeFromWatchlist.isPending &&
removeFromWatchlist.variables === pkg.id
}
/>
))
)}
</Card>
</div>
Expand Down