Skip to content

fix: use localStorage for Stytch return URL #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulvanbrenk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use localStorage for Stytch return URL #559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions patchnotes-web/src/auth/stytch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ if (import.meta.env.DEV) {
}

export function getStytchLoginConfig(returnUrl?: string) {
const base = `${window.location.origin}/authenticate`
const redirectURL = returnUrl
? `${base}?returnUrl=${encodeURIComponent(returnUrl)}`
: base
if (returnUrl) {
localStorage.setItem('stytch_return_url', returnUrl)
}
const redirectURL = `${window.location.origin}/authenticate`

return {
products,
Expand Down
5 changes: 4 additions & 1 deletion patchnotes-web/src/pages/Authenticate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ export function Authenticate() {

const { token, tokenType, returnUrl } = useMemo(() => {
const params = new URLSearchParams(window.location.search)
const raw = params.get('returnUrl')
// Check localStorage first, then fall back to query param for backwards compat
const stored = localStorage.getItem('stytch_return_url')
localStorage.removeItem('stytch_return_url')
const raw = stored ?? params.get('returnUrl')
return {
token: params.get('token'),
tokenType: params.get('stytch_token_type'),
Expand Down