Merged
Conversation
The parser now detects function-as-value references — identifiers in value positions that refer to functions without directly calling them. This covers the most common static patterns that cause false positives in dead code detection.
Patterns detected (JS/TS and Python):
┌───────────────────────┬───────────────────┐
│ Pattern │ Example │
├───────────────────────┼───────────────────┤
│ Object literal values │ { handler: myFn } │
├───────────────────────┼───────────────────┤
│ Shorthand properties │ { myFn } │
├───────────────────────┼───────────────────┤
│ Property assignments │ map['key'] = myFn │
├───────────────────────┼───────────────────┤
│ Array/list elements │ [fn1, fn2, fn3] │
├───────────────────────┼───────────────────┤
│ Callback arguments │ register(myFn) │
├───────────────────────┼───────────────────┤
│ Python dict values │ {'key': my_fn} │
└───────────────────────┴───────────────────┘
Files modified:
- code_review_graph/parser.py — Added _extract_value_references method with 5 sub-extractors (_ref_from_pair, _ref_from_assignment, _ref_from_array, _ref_from_arguments, _emit_reference_if_known). Updated _resolve_call_targets to resolve REFERENCES edges. Integrated into _extract_from_tree.
- code_review_graph/refactor.py — find_dead_code now checks for REFERENCES edges. Updated docstring with dynamic dispatch caveats.
- code_review_graph/graph.py — Updated edge kind documentation.
- tests/test_parser.py — 12 new tests in TestValueReferences class.
- tests/test_refactor.py — 4 new tests in TestFindDeadCodeWithReferences class.
- tests/fixtures/sample_map_dispatch.ts — New TS fixture with dispatch patterns.
- tests/fixtures/sample_map_dispatch.py — New Python fixture with dispatch patterns.
Safety constraints:
- Only emits REFERENCES for identifiers that are known (in defined_names or import_map)
- Filters out constants (all-uppercase), single-char names, and language keywords
- Works at both module scope and function scope
Known remaining limitations (documented in docstring):
- Fully dynamic keys (map[computedKey()] = fn) — requires abstract interpretation
- Reflect.apply / Function.prototype.call indirection
- Runtime require() / dynamic import()
New Python fixture with dispatch patterns.
Contributor
Author
|
On a small repo I'm working on... |
tirth8205
added a commit
that referenced
this pull request
Apr 11, 2026
Unreleased fixes since v2.2.2 that users are complaining about: - #208 Claude Code hook schema (fixes #97, #138, #163, #168, #172, #182, #188, #191, #201) — v2.2.2 generates an invalid hooks schema and timeouts in ms instead of seconds; PreCommit is also not a real event. - #205 SQLite transaction nesting (fixes #110, #135, #181) — implicit transactions from the legacy sqlite3 default caused "cannot start a transaction within a transaction" on update. - #166 Go method receivers resolved from field_identifier. - #170 UTF-8 decode errors in detect_changes (fixes #169). - #142 --platform target filters (fixes #133). - #213 / #183 large-repo community detection hangs. - #220 CI lint + tomllib on Python 3.10. - #159 missing pytest-cov dev dep. - #154 JSX component CALLS edges. Plus features: #177 Codex, #165 Luau (#153), #217 REFERENCES edge, #215 recurse_submodules, #185 gitignore default (#175), #171 gitignore docs (#157). Verified locally on Python 3.11: ruff clean, mypy clean, bandit clean, 691 tests pass, coverage 73.72%. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
tirth8205
added a commit
that referenced
this pull request
Apr 11, 2026
Unreleased fixes since v2.2.2 that users are complaining about: - #208 Claude Code hook schema (fixes #97, #138, #163, #168, #172, #182, #188, #191, #201) — v2.2.2 generates an invalid hooks schema and timeouts in ms instead of seconds; PreCommit is also not a real event. - #205 SQLite transaction nesting (fixes #110, #135, #181) — implicit transactions from the legacy sqlite3 default caused "cannot start a transaction within a transaction" on update. - #166 Go method receivers resolved from field_identifier. - #170 UTF-8 decode errors in detect_changes (fixes #169). - #142 --platform target filters (fixes #133). - #213 / #183 large-repo community detection hangs. - #220 CI lint + tomllib on Python 3.10. - #159 missing pytest-cov dev dep. - #154 JSX component CALLS edges. Plus features: #177 Codex, #165 Luau (#153), #217 REFERENCES edge, #215 recurse_submodules, #185 gitignore default (#175), #171 gitignore docs (#157). Verified locally on Python 3.11: ruff clean, mypy clean, bandit clean, 691 tests pass, coverage 73.72%. Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps mitigate #160 with new REFERENCES edge type.
The parser now detects function-as-value references — identifiers in value positions that refer to functions without directly calling them. This covers the most common static patterns that cause false positives in dead code detection.
Patterns detected (JS/TS and Python):
Files modified:
code_review_graph/parser.py— Added _extract_value_references method with 5 sub-extractors (_ref_from_pair, _ref_from_assignment, _ref_from_array, _ref_from_arguments, _emit_reference_if_known). Updated _resolve_call_targets to resolve REFERENCES edges. Integrated into _extract_from_tree.code_review_graph/refactor.py— find_dead_code now checks for REFERENCES edges. Updated docstring with dynamic dispatch caveats.code_review_graph/graph.py— Updated edge kind documentation.tests/test_parser.py— 12 new tests in TestValueReferences class.tests/test_refactor.py— 4 new tests in TestFindDeadCodeWithReferences class.tests/fixtures/sample_map_dispatch.ts— New TS fixture with dispatch patterns.tests/fixtures/sample_map_dispatch.py— New Python fixture with dispatch patterns.Safety constraints:
Known remaining limitations (documented in docstring):