Sync dev to main

[tis24dev]

• Skip privilege-sensitive failures in rootless env
• Simplify blkid unprivileged messages and logs

[Copilot]

Pull request overview

Adds unprivileged/rootless environment detection and uses it to downgrade known “missing privileges” failures (e.g., dmidecode, blkid) from WARNING to SKIP, with supporting tests and user-facing documentation.

Changes:

• Introduce unprivileged container detection via /proc/self/{uid_map,gid_map} and surface details for logging.
• Add privilege-sensitive failure classification (allowlist + output/exit-code heuristics) and apply it in command collection paths.
• Document the new SKIP ... Expected in unprivileged containers behavior and restore impact when blkid inventory is missing.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
internal/environment/unprivileged.go	Implements best-effort unprivileged/rootless detection via uid/gid maps and optional container hint.
internal/environment/unprivileged_test.go	Adds unit tests for parsing id maps and detection behavior.
internal/backup/collector_deps.go	Adds DI hook for unprivileged detection to support deterministic tests.
internal/backup/collector_unprivileged.go	Adds cached (sync.Once) unprivileged detection integration for Collector.
internal/backup/collector_privilege_sensitive.go	Adds allowlisted privilege-sensitive command failure matching.
internal/backup/collector_privilege_sensitive_test.go	Adds tests ensuring certain failures are downgraded to SKIP in unprivileged envs.
internal/backup/collector.go	Applies downgrade logic to safeCmdOutput and captureCommandOutput when in unprivileged context.
docs/TROUBLESHOOTING.md	Documents the new SKIP behavior in unprivileged containers and how to verify uid/gid maps.
docs/RESTORE_TECHNICAL.md	Notes restore limitations when block-device inventory is missing from unprivileged backups.
docs/RESTORE_GUIDE.md	Adds a user-facing note about remap limitations for unprivileged/rootless backups.
docs/CLI_REFERENCE.md	Documents log labels including SKIP and provides examples.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

exitCode is set to -1 when err is not an *exec.ExitError (e.g., context cancellation/timeout). In that case, privilegeSensitiveFailureMatch() can still match dmidecode via exitCode != 0 && outputText == "", causing timeouts/cancellations to be incorrectly downgraded to SKIP. Consider passing an additional flag indicating whether the exit code is known, or only applying the exit!=0 && empty output heuristic when errors.As(err, *exec.ExitError) succeeds (or when exitCode >= 0).

Suggested change

	match := privilegeSensitiveFailureMatch(cmdParts[0], exitCode, outputText)
	reason = match.Reason
	c.logger.Debug("Privilege-sensitive classification: command=%q matched=%t match=%q reason=%q", cmdParts[0], reason != "", match.Match, reason)
	if exitCode >= 0 {
	match := privilegeSensitiveFailureMatch(cmdParts[0], exitCode, outputText)
	reason = match.Reason
	c.logger.Debug("Privilege-sensitive classification: command=%q matched=%t match=%q reason=%q", cmdParts[0], reason != "", match.Match, reason)
	} else {
	c.logger.Debug("Privilege-sensitive classification skipped: unknown or unavailable exit code (command=%q exitCode=%d)", cmdParts[0], exitCode)
	}

[Copilot]

Same downgrade issue as in safeCmdOutput: when err isn't an *exec.ExitError, exitCode remains -1 and dmidecode can match the exit!=0 && empty output fallback, incorrectly downgrading context deadline/cancel (and other non-exit errors) to SKIP. Gate the exit-code-based heuristics on having a known exit code (or on *exec.ExitError).

[Copilot]

The privilege-sensitive downgrade/logging block is duplicated in both safeCmdOutput and captureCommandOutput (context detection, matching, SKIP logging). This duplication increases the risk of the two paths drifting (e.g., new patterns or fixes applied to only one). Consider extracting a small helper that takes (command, exitCode, outputText, description, err) and returns whether to downgrade + the reason/match.

Suggested change

	ctxInfo := c.depDetectUnprivilegedContainer()
	c.logger.Debug("Unprivileged context evaluation: detected=%t details=%q", ctxInfo.Detected, strings.TrimSpace(ctxInfo.Details))
	reason := ""
	if ctxInfo.Detected {
	c.logger.Debug("Privilege-sensitive allowlist: command=%q allowlisted=%t", cmdParts[0], isPrivilegeSensitiveCommand(cmdParts[0]))
	match := privilegeSensitiveFailureMatch(cmdParts[0], exitCode, outputText)
	reason = match.Reason
	c.logger.Debug("Privilege-sensitive classification: command=%q matched=%t match=%q reason=%q", cmdParts[0], reason != "", match.Match, reason)
	} else {
	c.logger.Debug("Privilege-sensitive downgrade not considered: unprivileged context not detected (command=%q)", cmdParts[0])
	}
	if ctxInfo.Detected && reason != "" {
	c.logger.Debug("Downgrading WARNING->SKIP: description=%q cmd=%q exitCode=%d", description, cmdString, exitCode)
	c.logger.Skip("Skipping %s: %s (Expected in unprivileged containers).", description, reason)
	c.logger.Debug("SKIP context (privilege-sensitive): description=%q cmd=%q exitCode=%d err=%v unprivilegedDetails=%q", description, cmdString, exitCode, err, strings.TrimSpace(ctxInfo.Details))
	c.logger.Debug("SKIP output summary for %s: %s", description, summarizeCommandOutputText(outputText))
	return nil
	}
	if ctxInfo.Detected {
	c.logger.Debug("No privilege-sensitive downgrade applied: command=%q did not match known patterns; emitting WARNING", cmdParts[0])
	}
	// Centralized privilege-sensitive downgrade evaluation.
	shouldDowngrade, reason, unprivDetails := c.evaluatePrivilegeSensitiveDowngrade(
	cmdParts[0],
	exitCode,
	outputText,
	description,
	err,
	"safeCmdOutput",
	)
	if shouldDowngrade {
	c.logger.Debug("Downgrading WARNING->SKIP: description=%q cmd=%q exitCode=%d", description, cmdString, exitCode)
	c.logger.Skip("Skipping %s: %s (Expected in unprivileged containers).", description, reason)
	c.logger.Debug("SKIP context (privilege-sensitive): description=%q cmd=%q exitCode=%d err=%v unprivilegedDetails=%q", description, cmdString, exitCode, err, unprivDetails)
	c.logger.Debug("SKIP output summary for %s: %s", description, summarizeCommandOutputText(outputText))
	return nil
	}

[codecov]

Codecov Report

❌ Patch coverage is 86.66667% with 22 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
internal/backup/collector_privilege_sensitive.go	86.66%	8 Missing ⚠️
internal/environment/unprivileged.go	80.00%	4 Missing and 4 partials ⚠️
internal/backup/collector.go	91.30%	2 Missing and 2 partials ⚠️
internal/backup/collector_unprivileged.go	89.47%	1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!