Skip to content

Fixes downloading on m1 macs from version 106.0.5249.61 #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kapoorlakshya merged 1 commit into from
Sep 29, 2022
Merged

Fixes downloading on m1 macs from version 106.0.5249.61 #239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lib/webdrivers/chromedriver.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,14 @@ def apple_m1_compatible?(driver_version)
false
end

def apple_filename(driver_version)
if apple_m1_compatible?(driver_version)
driver_version >= normalize_version('106.0.5249.61') ? 'mac_arm64' : 'mac64_m1'
else
'mac64'
end
end

def direct_url(driver_version)
"#{base_url}/#{driver_version}/chromedriver_#{driver_filename(driver_version)}.zip"
end
Expand All @@ -107,8 +115,7 @@ def driver_filename(driver_version)
elsif System.platform == 'linux'
'linux64'
elsif System.platform == 'mac'
apple_arch = apple_m1_compatible?(driver_version) ? '_m1' : ''
"mac64#{apple_arch}"
apple_filename(driver_version)
else
raise 'Failed to determine driver filename to download for your OS.'
end
Expand Down