Skip to content

[test_diff_functions_git.py] Test when current branch tracks other version#2

Merged
tkruse merged 11 commits into
tkruse:divergencefrom
wkentaro:add-test-for-other-remote-tracking
Jul 26, 2015
Merged

[test_diff_functions_git.py] Test when current branch tracks other version#2
tkruse merged 11 commits into
tkruse:divergencefrom
wkentaro:add-test-for-other-remote-tracking

Conversation

@wkentaro
Copy link
Copy Markdown

No description provided.

@wkentaro wkentaro changed the title Add test for other remote tracking [test_diff_functions_git.py] Test when current branch tracks other version Jul 26, 2015
@wkentaro
Copy link
Copy Markdown
Author

Related to: vcstools#38

tkruse added a commit that referenced this pull request Jul 26, 2015
[test_diff_functions_git.py] Test when current branch tracks other version
@tkruse tkruse merged commit 6d67a1f into tkruse:divergence Jul 26, 2015
@wkentaro wkentaro deleted the add-test-for-other-remote-tracking branch July 26, 2015 14:22
@tkruse
Copy link
Copy Markdown
Owner

tkruse commented Jul 26, 2015

This all looks great, thank you. So there is the problem of implementing --fetch, and the implementation for Mercurial missing. I think in vcstools, we could extend def get_remote_version(self, spec=None): with def get_remote_version(self, spec=None, fetch=False):

In wstools, we'd need to add the option in multiproject_cli, pass it to commin_cli:get_info_table, and pass it to config_elements:get_versioned_path_spec().

Would you like to do that?

BTW: In the commit messages, I would not mention the filename. It does not work well when squashing commits, and tools can easily show which files are changed anyway. But it is not a problem.

@wkentaro
Copy link
Copy Markdown
Author

I agree with the idea to pass fetch option like wstool info --fetch, and pass its fetch bool value to the following functions.

BTW:

I see. I will stop writing filename in commit messages when it is not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants