Large hashes with small curves#168
Merged
tomato42 merged 2 commits intotlsfuzzer:masterfrom Dec 16, 2019
Merged
Conversation
While not recommended, it is well-defined, so allow use of large hashes with small curve (like SHA-512 with NIST256p) test against OpenSSL
such use will not work in tox 4, so fix it before it breaks
tomato42
force-pushed
the
large_hashes
branch
from
259a53c to
73a245f
Compare
sahanaprasad07
approved these changes
Dec 16, 2019
sahanaprasad07
left a comment
sahanaprasad07
left a comment
There was a problem hiding this comment.
looks good to me!
nit : specify where it is well-defined in the commit description - a doc reference and maybe mention the RFC that does not recommend the usage
( While not recommended, it is well-defined)
Member
Author
|
It's specified in X9.62 but it's not freely available – the fact that it interoperates with openssl will need to suffice. I wasn't able to find either RFC or NIST SP document that would explicitly state the procedure (both redirect to X9.62) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #129