This repository was archived by the owner on May 16, 2025. It is now read-only.
Add SocketEngineType.DefaultTransport#69
Merged
Conversation
tmds
reviewed
Mar 20, 2020
| IOUringTransport, | ||
| LinuxTransport | ||
| LinuxTransport, | ||
| DefaultSockets |
Collaborator
Author
There was a problem hiding this comment.
I'm unsure. In many cases such naming is used to indicate that a default option is being picked from the remaining enum members.
Owner
There was a problem hiding this comment.
I know what you mean by default, though it is not the default here.
Maybe: KestrelDefaultTransport?
Anyway, feel free to pick what you like and merge this.
Collaborator
Author
There was a problem hiding this comment.
Ended up with the name DefaultTransport, since other variants also lack the Kestrel* prefix.
tmds
reviewed
Mar 20, 2020
| case SocketEngineType.DefaultSockets: | ||
| webBuilder.UseSockets(options => | ||
| { | ||
| options.DispatchContinuations = commandLineOptions.DispatchContinuations.Value; |
Owner
There was a problem hiding this comment.
@antonfirsov fyi, we've added an option for DontAllocateMemoryForIdleConnections in dotnet/aspnetcore#19396.
antonfirsov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can use the original
SocketsTransportas a baseline